Merge lp:~artem-anufrij/audience/Bugfix-1297408 into lp:~audience-members/audience/trunk

Proposed by Artem Anufrij
Status: Merged
Approved by: Cody Garver
Approved revision: 425
Merged at revision: 425
Proposed branch: lp:~artem-anufrij/audience/Bugfix-1297408
Merge into: lp:~audience-members/audience/trunk
Diff against target: 47 lines (+5/-6)
1 file modified
src/Audience.vala (+5/-6)
To merge this branch: bzr merge lp:~artem-anufrij/audience/Bugfix-1297408
Reviewer Review Type Date Requested Status
PerfectCarl (community) Approve
Audience Members Pending
Review via email: mp+238790@code.launchpad.net

Commit message

Respect playback_wait setting

Description of the change

if "playback_wait" has been set, Audience doesn't starts automatically playback after:
- start Audience
- open a video file (doubleclick) in Files
- open a video in Audience (open file dialog)
- drag and drop

To post a comment you must log in.
Revision history for this message
PerfectCarl (name-is-carl) wrote :

The code is clean.

Assuming it does what it says on the tin, it's all good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Audience.vala'
2--- src/Audience.vala 2014-10-05 05:04:18 +0000
3+++ src/Audience.vala 2014-10-18 09:12:19 +0000
4@@ -409,7 +409,7 @@
5
6 if (d.run () == Gtk.ResponseType.OK) {
7 open_file (entry.text, true);
8- video_player.playing = true;
9+ video_player.playing = !settings.playback_wait;
10 welcome.hide ();
11 clutter.show_all ();
12 }
13@@ -672,7 +672,7 @@
14
15 var root = volume.get_mount ().get_default_location ();
16 open_file (root.get_uri (), true);
17- video_player.playing = true;
18+ video_player.playing = !settings.playback_wait;
19
20 welcome.hide ();
21 clutter.show_all ();
22@@ -753,8 +753,7 @@
23 video_player.set_subtitle_uri (sub_uri);
24
25 mainwindow.title = get_title (uri);
26- if (!settings.playback_wait)
27- video_player.playing = true;
28+ video_player.playing = !settings.playback_wait;
29
30 Gtk.RecentManager recent_manager = Gtk.RecentManager.get_default ();
31 recent_manager.add_item (uri);
32@@ -779,7 +778,7 @@
33 open_file (settings.current_video);
34 video_player.playing = false;
35 Idle.add (() => {video_player.progress = settings.last_stopped; return false;});
36- video_player.playing = true;
37+ video_player.playing = !settings.playback_wait;
38 }
39 }
40 }
41@@ -819,4 +818,4 @@
42 var app = Audience.App.get_instance ();
43
44 app.run (args);
45-}
46+}
47\ No newline at end of file

Subscribers

People subscribed via source and target branches