Code review comment for ~arraybolt3/grub:ubuntu

Revision history for this message
Aaron Rainbolt (arraybolt3) wrote :

I should be up front - if this involves patching the C code component of the bootloader, I do not think I can do this. My C skills stink, and with a piece of software as security-critical as the bootloader, I don't trust myself to be able to modify GRUB's "kernel" without introducing the next Secure Boot-bypassing CVE on accident. That's part of the reason I did this in the shell scripts - GRUB has all the features to do this, so I tried to just leverage them.

If nothing else, hopefully this was at least an interesting proof-of-concept and we can try to get the actual implementation into 24.10. Still, I'm willing to try to make things work in an ideal way, just... get someone from the security team to grill my code if I do try to mess with the C stuff. :)

« Back to merge proposal