Code review comment for ~arraybolt3/grub:ubuntu

Revision history for this message
Aaron Rainbolt (arraybolt3) wrote :

My reasoning for wanting it in 24.04 isn't really a great excuse, but I work for an OEM that would really like for this to work in 24.04 for implementing a system restore feature. We have a fallback for if this isn't accepted, but it's not really an ideal one. For that reason I'd be happy to file the FFe. I totally understand if this is just too late for this cycle though.

I suppose always putting grubenv on ESP when running on EFI would work too. I intentionally didn't do that as I was trying to trip as little "gotchas" that may exist as possible by tweaking the code and the behavior as little as I could manage. I'm happy to rework this to simply say "if on an EFI system, put grubenv there instead". That would be significantly less complicated code-wise, though it would affect more scenarios and therefore potentially come with a greater regression risk.

« Back to merge proposal