Code review comment for ~arif-ali/charm-nagios:nrpe_v2_fix_config_changed

Revision history for this message
Arif Ali (arif-ali) wrote :

Below are the results from the lint and unit tests. The functional tests don't work, and hang after active/idle state of the model. Tried to fix that put the same issue with xenial. The xenial functional tests wouldn't work as the ch default channels didn't have xenial.

More work is required to get the functional tests to work. I may have a further dig, but if this can be reviewed without that, then that would help me

❱❱❱ tox -e lint | pastebinit
All done! ✨ 🍰 ✨
15 files would be left unchanged.
https://paste.ubuntu.com/p/JbhT49hKFz/

❱❱❱ tox -e unit | pastebinit
/home/arif/gitRepos/openstack/charm-nagios/.tox/unit/lib/python3.11/site-packages/coverage/inorout.py:503: CoverageWarning: Module lib was never imported. (module-not-imported)
  self.warn(f"Module {pkg} was never imported.", slug="module-not-imported")
/home/arif/gitRepos/openstack/charm-nagios/.tox/unit/lib/python3.11/site-packages/coverage/inorout.py:503: CoverageWarning: Module reactive was never imported. (module-not-imported)
  self.warn(f"Module {pkg} was never imported.", slug="module-not-imported")
/home/arif/gitRepos/openstack/charm-nagios/.tox/unit/lib/python3.11/site-packages/coverage/inorout.py:503: CoverageWarning: Module src was never imported. (module-not-imported)
  self.warn(f"Module {pkg} was never imported.", slug="module-not-imported")
https://paste.ubuntu.com/p/jDxK2GCDVn/

« Back to merge proposal