Merge lp:~ari-tczew/ubuntu/natty/webkit/lp-691104 into lp:ubuntu/natty/webkit

Proposed by Artur Rona
Status: Superseded
Proposed branch: lp:~ari-tczew/ubuntu/natty/webkit/lp-691104
Merge into: lp:ubuntu/natty/webkit
Diff against target: 493 lines (+435/-0)
10 files modified
debian/changelog (+52/-0)
debian/patches/05-fix-jit-on-kfreebsd-i386.patch (+51/-0)
debian/patches/cve-2010-2646.patch (+110/-0)
debian/patches/cve-2010-2651.patch (+38/-0)
debian/patches/cve-2010-2900.patch (+29/-0)
debian/patches/cve-2010-2901.patch (+98/-0)
debian/patches/cve-2010-3120.patch (+27/-0)
debian/patches/series (+7/-0)
debian/patches/typo_webkitwebsettings.patch (+18/-0)
debian/patches/ubuntu-gir-version.patch (+5/-0)
To merge this branch: bzr merge lp:~ari-tczew/ubuntu/natty/webkit/lp-691104
Reviewer Review Type Date Requested Status
Robert Ancell (community) Needs Resubmitting
Review via email: mp+43943@code.launchpad.net

Description of the change

I prepared a merge with Debian unstable, but there is a FTBFS. More information on bug report.

To post a comment you must log in.
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Merge is on wrong branch, packaging is here:
lp:~ubuntu-desktop/webkit/ubuntu

Note that the branch has been updated.

review: Needs Resubmitting
Revision history for this message
Artur Rona (ari-tczew) wrote :

> Merge is on wrong branch, packaging is here:
> lp:~ubuntu-desktop/webkit/ubuntu
>
> Note that the branch has been updated.

I don't like when someone signs my work as its...

Unmerged revisions

22. By Artur Rona

  [ Artur Rona ]
  * Merge from debian unstable. Remaining changes: (LP: #691104)
    - debian/control: Drop Build-Depends on gir-repository-dev since
      we don't have this package in archive.
    - debian/patches/ubuntu-gir-version.patch: Use the 1.2 gobject
      introspection abi.

  [ David Stansby ]
  * debian/patches/typo_webkitwebsettings.patch: Fix typo. (LP: #552718)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2010-10-21 13:40:42 +0000
+++ debian/changelog 2010-12-16 18:14:15 +0000
@@ -1,3 +1,55 @@
1webkit (1.2.5-2.1ubuntu1) natty; urgency=low
2
3 [ Artur Rona ]
4 * Merge from debian unstable. Remaining changes: (LP: #691104)
5 - debian/control: Drop Build-Depends on gir-repository-dev since
6 we don't have this package in archive.
7 - debian/patches/ubuntu-gir-version.patch: Use the 1.2 gobject
8 introspection abi.
9
10 [ David Stansby ]
11 * debian/patches/typo_webkitwebsettings.patch: Fix typo. (LP: #552718)
12
13 -- Artur Rona <ari-tczew@ubuntu.com> Thu, 16 Dec 2010 15:02:49 +0100
14
15webkit (1.2.5-2.1) unstable; urgency=low
16
17 * Non-maintainer upload.
18 * Add patch 05-fix-jit-on-kfreebsd-i386.patch by Petr Salinger and
19 Michael Dorrington: Fixes Javascript JIT crashing on kfreebsd-i386
20 (closes: #598956).
21
22 -- gregor herrmann <gregoa@debian.org> Wed, 10 Nov 2010 23:28:55 +0100
23
24webkit (1.2.5-2) unstable; urgency=high
25
26 * Unapply 02-pool-fixup-and-sparc-support.patch and
27 04-spoof-user-agent-to-google.patch in git. This prevents the
28 creation of an unwanted debian-changes patch.
29
30 -- Michael Gilbert <michael.s.gilbert@gmail.com> Mon, 18 Oct 2010 22:00:36 -0400
31
32webkit (1.2.5-1) unstable; urgency=high
33
34 [ Gustavo Noronha Silva ]
35
36 * New upstream release
37 - fixes the following CVES:
38
39 CVE-2010-1780 CVE-2010-3113 CVE-2010-1814 CVE-2010-1812
40 CVE-2010-1815 CVE-2010-3115 CVE-2010-1807 CVE-2010-3114
41 CVE-2010-3116 CVE-2010-3257 CVE-2010-3259
42
43 [ Michael Gilbert ]
44 * fix cve-2010-2646: security origin bypass using IFRAME elements.
45 * fix cve-2010-2651: vulnerability in css style rendering.
46 * fix cve-2010-2900: vulnerability with large canvas elements when using the
47 SKIA library.
48 * fix cve-2010-2901: vulnerability in the rendering implementation.
49 * fix cve-2010-3120: vulnerability in geolocation feature.
50
51 -- Gustavo Noronha Silva <kov@debian.org> Sat, 16 Oct 2010 17:50:56 -0300
52
1webkit (1.2.5-0ubuntu3) natty; urgency=low53webkit (1.2.5-0ubuntu3) natty; urgency=low
254
3 * debian/patches/ubuntu-gir-version.patch:55 * debian/patches/ubuntu-gir-version.patch:
456
=== added file 'debian/patches/05-fix-jit-on-kfreebsd-i386.patch'
--- debian/patches/05-fix-jit-on-kfreebsd-i386.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/05-fix-jit-on-kfreebsd-i386.patch 2010-12-16 18:14:15 +0000
@@ -0,0 +1,51 @@
1Author: Petr Salinger
2Tester: Michael Dorrington
3Description: Fixes Javascript JIT crashing on kfreebsd-i386.
4 Fixes Javascript JIT issue that causes webkit to crash on kfreebsd-i386,
5 see <http://bugs.debian.org/598956>.
6
7 For reasoning of patch see:
8 "Common practices and problems found when porting to GNU/k*BSD"
9 <http://glibc-bsd.alioth.debian.org/porting/PORTING>
10
11 On kfreebsd-amd64, this issue does not occur.
12
13
14--- webkit-1.2.4/JavaScriptCore/jit/JITOpcodes.cpp 2010-09-03 20:18:02.000000000 +0100
15+++ webkit-1.2.4-fix_jit_kfreebsd_i386/JavaScriptCore/jit/JITOpcodes.cpp 2010-10-07 06:09:55.000000000 +0100
16@@ -165,7 +165,7 @@
17 * stack pointer by the right amount after the call.
18 */
19
20-#if COMPILER(MSVC) || OS(LINUX)
21+#if COMPILER(MSVC) || OS(LINUX) || defined(__GLIBC__)
22 #if COMPILER(MSVC)
23 #pragma pack(push)
24 #pragma pack(4)
25@@ -228,7 +228,7 @@
26 storePtr(regT2, Address(stackPointerRegister, OBJECT_OFFSETOF(NativeCallFrameStructure, thisValue) + OBJECT_OFFSETOF(JSValue, u.asBits.payload)));
27 storePtr(regT3, Address(stackPointerRegister, OBJECT_OFFSETOF(NativeCallFrameStructure, thisValue) + OBJECT_OFFSETOF(JSValue, u.asBits.tag)));
28
29-#if COMPILER(MSVC) || OS(LINUX)
30+#if COMPILER(MSVC) || OS(LINUX) || defined(__GLIBC__)
31 // ArgList is passed by reference so is stackPointerRegister + 4 * sizeof(Register)
32 addPtr(Imm32(OBJECT_OFFSETOF(NativeCallFrameStructure, result)), stackPointerRegister, X86Registers::ecx);
33
34@@ -1689,7 +1689,7 @@
35 * not the rest of the callframe so we need a nice way to ensure we increment the
36 * stack pointer by the right amount after the call.
37 */
38-#if COMPILER(MSVC) || OS(LINUX)
39+#if COMPILER(MSVC) || OS(LINUX) || defined(__GLIBC__)
40 struct NativeCallFrameStructure {
41 // CallFrame* callFrame; // passed in EDX
42 JSObject* callee;
43@@ -1742,7 +1742,7 @@
44 loadPtr(Address(regT1, -(int)sizeof(Register)), regT1);
45 storePtr(regT1, Address(stackPointerRegister, OBJECT_OFFSETOF(NativeCallFrameStructure, thisValue)));
46
47-#if COMPILER(MSVC) || OS(LINUX)
48+#if COMPILER(MSVC) || OS(LINUX) || defined(__GLIBC__)
49 // ArgList is passed by reference so is stackPointerRegister + 4 * sizeof(Register)
50 addPtr(Imm32(OBJECT_OFFSETOF(NativeCallFrameStructure, result)), stackPointerRegister, X86Registers::ecx);
51
052
=== added file 'debian/patches/cve-2010-2646.patch'
--- debian/patches/cve-2010-2646.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/cve-2010-2646.patch 2010-12-16 18:14:15 +0000
@@ -0,0 +1,110 @@
1description: fix cve-2010-2646
2author: Michael Gilbert <michael.s.gilbert@gmail.com>
3origin: http://trac.webkit.org/changeset/58873
4Index: webkit-1.2.4/WebCore/storage/StorageEventDispatcher.cpp
5===================================================================
6--- webkit-1.2.4.orig/WebCore/storage/StorageEventDispatcher.cpp 2010-09-07 01:13:45.000000000 -0400
7+++ webkit-1.2.4/WebCore/storage/StorageEventDispatcher.cpp 2010-09-07 01:14:42.000000000 -0400
8@@ -54,8 +54,12 @@
9 frames.append(frame);
10 }
11
12- for (unsigned i = 0; i < frames.size(); ++i)
13- frames[i]->document()->enqueueStorageEvent(StorageEvent::create(eventNames().storageEvent, key, oldValue, newValue, sourceFrame->document()->url(), frames[i]->domWindow()->sessionStorage()));
14+ for (unsigned i = 0; i < frames.size(); ++i) {
15+ ExceptionCode ec = 0;
16+ Storage* storage = frames[i]->domWindow()->sessionStorage(ec);
17+ if (!ec)
18+ frames[i]->document()->enqueueStorageEvent(StorageEvent::create(eventNames().storageEvent, key, oldValue, newValue, sourceFrame->document()->url(), storage));
19+ }
20 } else {
21 // Send events to every page.
22 const HashSet<Page*>& pages = page->group().pages();
23Index: webkit-1.2.4/WebCore/page/DOMWindow.h
24===================================================================
25--- webkit-1.2.4.orig/WebCore/page/DOMWindow.h 2010-09-07 01:13:45.000000000 -0400
26+++ webkit-1.2.4/WebCore/page/DOMWindow.h 2010-09-07 01:14:42.000000000 -0400
27@@ -206,7 +206,7 @@
28
29 #if ENABLE(DOM_STORAGE)
30 // HTML 5 key/value storage
31- Storage* sessionStorage() const;
32+ Storage* sessionStorage(ExceptionCode&) const;
33 Storage* localStorage(ExceptionCode&) const;
34 #endif
35
36Index: webkit-1.2.4/WebCore/page/DOMWindow.cpp
37===================================================================
38--- webkit-1.2.4.orig/WebCore/page/DOMWindow.cpp 2010-09-07 01:13:45.000000000 -0400
39+++ webkit-1.2.4/WebCore/page/DOMWindow.cpp 2010-09-07 01:14:42.000000000 -0400
40@@ -567,7 +567,7 @@
41 }
42
43 #if ENABLE(DOM_STORAGE)
44-Storage* DOMWindow::sessionStorage() const
45+Storage* DOMWindow::sessionStorage(ExceptionCode& ec) const
46 {
47 if (m_sessionStorage)
48 return m_sessionStorage.get();
49@@ -576,6 +576,11 @@
50 if (!document)
51 return 0;
52
53+ if (!document->securityOrigin()->canAccessLocalStorage()) {
54+ ec = SECURITY_ERR;
55+ return 0;
56+ }
57+
58 Page* page = document->page();
59 if (!page)
60 return 0;
61@@ -593,16 +598,16 @@
62 {
63 if (m_localStorage)
64 return m_localStorage.get();
65-
66+
67 Document* document = this->document();
68 if (!document)
69 return 0;
70-
71+
72 if (!document->securityOrigin()->canAccessLocalStorage()) {
73 ec = SECURITY_ERR;
74 return 0;
75 }
76-
77+
78 Page* page = document->page();
79 if (!page)
80 return 0;
81Index: webkit-1.2.4/WebCore/page/SecurityOrigin.h
82===================================================================
83--- webkit-1.2.4.orig/WebCore/page/SecurityOrigin.h 2010-09-07 01:13:45.000000000 -0400
84+++ webkit-1.2.4/WebCore/page/SecurityOrigin.h 2010-09-07 01:14:42.000000000 -0400
85@@ -120,6 +120,11 @@
86 bool canAccessLocalStorage() const { return !isUnique(); }
87 bool canAccessCookies() const { return !isUnique(); }
88
89+ // Technically, we should always allow access to sessionStorage, but we
90+ // currently don't handle creating a sessionStorage area for unique
91+ // origins.
92+ bool canAccessSessionStorage() const { return !isUnique(); }
93+
94 bool isSecureTransitionTo(const KURL&) const;
95
96 // The local SecurityOrigin is the most privileged SecurityOrigin.
97Index: webkit-1.2.4/WebCore/page/DOMWindow.idl
98===================================================================
99--- webkit-1.2.4.orig/WebCore/page/DOMWindow.idl 2010-09-07 01:14:36.000000000 -0400
100+++ webkit-1.2.4/WebCore/page/DOMWindow.idl 2010-09-07 01:14:42.000000000 -0400
101@@ -164,7 +164,8 @@
102 raises(DOMException);
103 #endif
104 #if defined(ENABLE_DOM_STORAGE) && ENABLE_DOM_STORAGE
105- readonly attribute [EnabledAtRuntime] Storage sessionStorage;
106+ readonly attribute [EnabledAtRuntime] Storage sessionStorage
107+ getter raises(DOMException);
108 readonly attribute [EnabledAtRuntime] Storage localStorage
109 getter raises(DOMException);
110 #endif
0111
=== added file 'debian/patches/cve-2010-2651.patch'
--- debian/patches/cve-2010-2651.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/cve-2010-2651.patch 2010-12-16 18:14:15 +0000
@@ -0,0 +1,38 @@
1description: fix cve-2010-2651
2author: Michael Gilbert <michael.s.gilbert@gmail.com>
3origin: http://trac.webkit.org/changeset/59247
4Index: webkit-1.2.4/WebCore/rendering/RenderBlock.cpp
5===================================================================
6--- webkit-1.2.4.orig/WebCore/rendering/RenderBlock.cpp 2010-09-03 15:18:07.000000000 -0400
7+++ webkit-1.2.4/WebCore/rendering/RenderBlock.cpp 2010-09-06 21:50:51.000000000 -0400
8@@ -4651,10 +4651,12 @@
9
10 // Drill into inlines looking for our first text child.
11 RenderObject* currChild = firstLetterBlock->firstChild();
12- while (currChild && currChild->needsLayout() && ((!currChild->isReplaced() && !currChild->isRenderButton() && !currChild->isMenuList()) || currChild->isFloatingOrPositioned()) && !currChild->isText()) {
13+ while (currChild && ((!currChild->isReplaced() && !currChild->isRenderButton() && !currChild->isMenuList()) || currChild->isFloatingOrPositioned()) && !currChild->isText()) {
14 if (currChild->isFloatingOrPositioned()) {
15- if (currChild->style()->styleType() == FIRST_LETTER)
16+ if (currChild->style()->styleType() == FIRST_LETTER) {
17+ currChild = currChild->firstChild();
18 break;
19+ }
20 currChild = currChild->nextSibling();
21 } else
22 currChild = currChild->firstChild();
23@@ -4671,11 +4673,11 @@
24
25 // If the child already has style, then it has already been created, so we just want
26 // to update it.
27- if (currChild->style()->styleType() == FIRST_LETTER) {
28+ if (firstLetterContainer->style()->styleType() == FIRST_LETTER) {
29 RenderStyle* pseudo = firstLetterBlock->getCachedPseudoStyle(FIRST_LETTER,
30- firstLetterContainer->firstLineStyle());
31- currChild->setStyle(pseudo);
32- for (RenderObject* genChild = currChild->firstChild(); genChild; genChild = genChild->nextSibling()) {
33+ firstLetterContainer->parent()->firstLineStyle());
34+ firstLetterContainer->setStyle(pseudo);
35+ for (RenderObject* genChild = firstLetterContainer->firstChild(); genChild; genChild = genChild->nextSibling()) {
36 if (genChild->isText())
37 genChild->setStyle(pseudo);
38 }
039
=== added file 'debian/patches/cve-2010-2900.patch'
--- debian/patches/cve-2010-2900.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/cve-2010-2900.patch 2010-12-16 18:14:15 +0000
@@ -0,0 +1,29 @@
1description: fix cve-2010-2900
2author: Michael Gilbert <michael.s.gilbert@gmail.com>
3origin: http://trac.webkit.org/changeset/63219
4Index: webkit-1.2.4/WebCore/html/HTMLCanvasElement.cpp
5===================================================================
6--- webkit-1.2.4.orig/WebCore/html/HTMLCanvasElement.cpp 2010-09-06 22:28:56.000000000 -0400
7+++ webkit-1.2.4/WebCore/html/HTMLCanvasElement.cpp 2010-09-06 22:29:28.000000000 -0400
8@@ -64,6 +64,9 @@
9 // in exchange for a smaller maximum canvas size.
10 const float HTMLCanvasElement::MaxCanvasArea = 32768 * 8192; // Maximum canvas area in CSS pixels
11
12+//In Skia, we will also limit width/height to 32767.
13+static const float MaxSkiaDim = 32767.0F; // Maximum width/height in CSS pixels.
14+
15 HTMLCanvasElement::HTMLCanvasElement(const QualifiedName& tagName, Document* doc)
16 : HTMLElement(tagName, doc)
17 , m_size(defaultWidth, defaultHeight)
18@@ -293,6 +296,11 @@
19 if (!(wf >= 1 && hf >= 1 && wf * hf <= MaxCanvasArea))
20 return IntSize();
21
22+#if PLATFORM(SKIA)
23+ if (wf > MaxSkiaDim || hf > MaxSkiaDim)
24+ return IntSize();
25+#endif
26+
27 return IntSize(static_cast<unsigned>(wf), static_cast<unsigned>(hf));
28 }
29
030
=== added file 'debian/patches/cve-2010-2901.patch'
--- debian/patches/cve-2010-2901.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/cve-2010-2901.patch 2010-12-16 18:14:15 +0000
@@ -0,0 +1,98 @@
1description: fix cve-2010-2901
2author: Michael Gilbert <michael.s.gilbert@gmail.com>
3origin: http://trac.webkit.org/changeset/63048
4Index: webkit-1.2.4/WebCore/rendering/RenderObject.cpp
5===================================================================
6--- webkit-1.2.4.orig/WebCore/rendering/RenderObject.cpp 2010-09-06 22:55:29.000000000 -0400
7+++ webkit-1.2.4/WebCore/rendering/RenderObject.cpp 2010-09-06 22:56:03.000000000 -0400
8@@ -560,6 +560,19 @@
9 return 0;
10 }
11
12+RenderBoxModelObject* RenderObject::enclosingBoxModelObject() const
13+{
14+ RenderObject* curr = const_cast<RenderObject*>(this);
15+ while (curr) {
16+ if (curr->isBoxModelObject())
17+ return toRenderBoxModelObject(curr);
18+ curr = curr->parent();
19+ }
20+
21+ ASSERT_NOT_REACHED();
22+ return 0;
23+}
24+
25 RenderBlock* RenderObject::firstLineBlock() const
26 {
27 return 0;
28Index: webkit-1.2.4/WebCore/rendering/RenderObject.h
29===================================================================
30--- webkit-1.2.4.orig/WebCore/rendering/RenderObject.h 2010-09-06 22:55:29.000000000 -0400
31+++ webkit-1.2.4/WebCore/rendering/RenderObject.h 2010-09-06 22:56:03.000000000 -0400
32@@ -193,7 +193,8 @@
33
34 // Convenience function for getting to the nearest enclosing box of a RenderObject.
35 RenderBox* enclosingBox() const;
36-
37+ RenderBoxModelObject* enclosingBoxModelObject() const;
38+
39 virtual bool isEmpty() const { return firstChild() == 0; }
40
41 #ifndef NDEBUG
42Index: webkit-1.2.4/WebCore/rendering/InlineFlowBox.cpp
43===================================================================
44--- webkit-1.2.4.orig/WebCore/rendering/InlineFlowBox.cpp 2010-09-06 22:55:28.000000000 -0400
45+++ webkit-1.2.4/WebCore/rendering/InlineFlowBox.cpp 2010-09-06 22:56:24.000000000 -0400
46@@ -639,11 +639,24 @@
47 // outlines.
48 if (renderer()->style()->visibility() == VISIBLE && renderer()->hasOutline() && !isRootInlineBox()) {
49 RenderInline* inlineFlow = toRenderInline(renderer());
50- if ((inlineFlow->continuation() || inlineFlow->isInlineContinuation()) && !boxModelObject()->hasSelfPaintingLayer()) {
51+
52+ RenderBlock* cb = 0;
53+ bool containingBlockPaintsContinuationOutline = inlineFlow->continuation() || inlineFlow->isInlineContinuation();
54+ if (containingBlockPaintsContinuationOutline) {
55+ cb = renderer()->containingBlock()->containingBlock();
56+
57+ for (RenderBoxModelObject* box = boxModelObject(); box != cb; box = box->parent()->enclosingBoxModelObject()) {
58+ if (box->hasSelfPaintingLayer()) {
59+ containingBlockPaintsContinuationOutline = false;
60+ break;
61+ }
62+ }
63+ }
64+
65+ if (containingBlockPaintsContinuationOutline) {
66 // Add ourselves to the containing block of the entire continuation so that it can
67 // paint us atomically.
68- RenderBlock* block = renderer()->containingBlock()->containingBlock();
69- block->addContinuationWithOutline(toRenderInline(renderer()->node()->renderer()));
70+ cb->addContinuationWithOutline(toRenderInline(renderer()->node()->renderer()));
71 } else if (!inlineFlow->isInlineContinuation())
72 paintInfo.outlineObjects->add(inlineFlow);
73 }
74Index: webkit-1.2.4/WebCore/rendering/RenderBlock.cpp
75===================================================================
76--- webkit-1.2.4.orig/WebCore/rendering/RenderBlock.cpp 2010-09-06 22:55:28.000000000 -0400
77+++ webkit-1.2.4/WebCore/rendering/RenderBlock.cpp 2010-09-06 22:56:03.000000000 -0400
78@@ -1766,8 +1766,18 @@
79 if ((paintPhase == PaintPhaseOutline || paintPhase == PaintPhaseChildOutlines)) {
80 if (inlineContinuation() && inlineContinuation()->hasOutline() && inlineContinuation()->style()->visibility() == VISIBLE) {
81 RenderInline* inlineRenderer = toRenderInline(inlineContinuation()->node()->renderer());
82- if (!inlineRenderer->hasSelfPaintingLayer())
83- containingBlock()->addContinuationWithOutline(inlineRenderer);
84+ RenderBlock* cb = containingBlock();
85+
86+ bool inlineEnclosedInSelfPaintingLayer = false;
87+ for (RenderBoxModelObject* box = inlineRenderer; box != cb; box = box->parent()->enclosingBoxModelObject()) {
88+ if (box->hasSelfPaintingLayer()) {
89+ inlineEnclosedInSelfPaintingLayer = true;
90+ break;
91+ }
92+ }
93+
94+ if (!inlineEnclosedInSelfPaintingLayer)
95+ cb->addContinuationWithOutline(inlineRenderer);
96 else if (!inlineRenderer->firstLineBox())
97 inlineRenderer->paintOutline(paintInfo.context, tx - x() + inlineRenderer->containingBlock()->x(),
98 ty - y() + inlineRenderer->containingBlock()->y());
099
=== added file 'debian/patches/cve-2010-3120.patch'
--- debian/patches/cve-2010-3120.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/cve-2010-3120.patch 2010-12-16 18:14:15 +0000
@@ -0,0 +1,27 @@
1description: fix cve-2010-3120
2author: Michael Gilbert <michael.s.gilbert@gmail.com>
3origin: http://trac.webkit.org/changeset/65329
4Index: webkit-1.2.4/WebCore/page/Geolocation.cpp
5===================================================================
6--- webkit-1.2.4.orig/WebCore/page/Geolocation.cpp 2010-09-03 15:18:06.000000000 -0400
7+++ webkit-1.2.4/WebCore/page/Geolocation.cpp 2010-09-06 22:14:03.000000000 -0400
8@@ -252,6 +252,9 @@
9
10 void Geolocation::getCurrentPosition(PassRefPtr<PositionCallback> successCallback, PassRefPtr<PositionErrorCallback> errorCallback, PassRefPtr<PositionOptions> options)
11 {
12+ if (!m_frame)
13+ return;
14+
15 RefPtr<GeoNotifier> notifier = startRequest(successCallback, errorCallback, options);
16 ASSERT(notifier);
17
18@@ -260,6 +263,9 @@
19
20 int Geolocation::watchPosition(PassRefPtr<PositionCallback> successCallback, PassRefPtr<PositionErrorCallback> errorCallback, PassRefPtr<PositionOptions> options)
21 {
22+ if (!m_frame)
23+ return 0;
24+
25 RefPtr<GeoNotifier> notifier = startRequest(successCallback, errorCallback, options);
26 ASSERT(notifier);
27
028
=== modified file 'debian/patches/series'
--- debian/patches/series 2010-10-21 13:40:42 +0000
+++ debian/patches/series 2010-12-16 18:14:15 +0000
@@ -1,3 +1,10 @@
102-pool-fixup-and-sparc-support.patch102-pool-fixup-and-sparc-support.patch
204-spoof-user-agent-to-google.patch204-spoof-user-agent-to-google.patch
305-fix-jit-on-kfreebsd-i386.patch
4cve-2010-2646.patch
5cve-2010-2651.patch
6cve-2010-2900.patch
7cve-2010-2901.patch
8cve-2010-3120.patch
3ubuntu-gir-version.patch9ubuntu-gir-version.patch
10typo_webkitwebsettings.patch
411
=== added file 'debian/patches/typo_webkitwebsettings.patch'
--- debian/patches/typo_webkitwebsettings.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/typo_webkitwebsettings.patch 2010-12-16 18:14:15 +0000
@@ -0,0 +1,18 @@
1From: Artur Rona <ari-tczew@ubuntu.com>
2Description: Fix typo in WebKit/gtk/webkit/webkitwebsettings.cpp.
3Bug-Ubuntu: https://launchpad.net/bugs/552718
4Origin: upstream, http://trac.webkit.org/changeset/64629/
5Author: David Stansby <dstansby@gmail.com>
6
7diff -pruN -x '*~' webkit-1.2.5.orig/WebKit/gtk/webkit/webkitwebsettings.cpp webkit-1.2.5/WebKit/gtk/webkit/webkitwebsettings.cpp
8--- webkit-1.2.5.orig/WebKit/gtk/webkit/webkitwebsettings.cpp 2010-12-16 13:31:40.000000000 +0100
9+++ webkit-1.2.5/WebKit/gtk/webkit/webkitwebsettings.cpp 2010-12-16 15:42:22.000000000 +0100
10@@ -578,7 +578,7 @@ static void webkit_web_settings_class_in
11 PROP_ENABLE_XSS_AUDITOR,
12 g_param_spec_boolean("enable-xss-auditor",
13 _("Enable XSS Auditor"),
14- _("Whether to enable teh XSS auditor"),
15+ _("Whether to enable the XSS auditor"),
16 TRUE,
17 flags));
18 /**
019
=== modified file 'debian/patches/ubuntu-gir-version.patch'
--- debian/patches/ubuntu-gir-version.patch 2010-10-21 13:40:42 +0000
+++ debian/patches/ubuntu-gir-version.patch 2010-12-16 18:14:15 +0000
@@ -1,3 +1,8 @@
1From: Artur Rona <ari-tczew@ubuntu.com>
2Description: Use the 1.2 gobject introspection abi.
3Forwarded: not-needed
4Author: Robert Ancell <robert.ancell@canonical.com>
5
1Index: webkit-1.2.5/WebKit/gtk/JSCore-1.0.gir6Index: webkit-1.2.5/WebKit/gtk/JSCore-1.0.gir
2===================================================================7===================================================================
3--- webkit-1.2.5.orig/WebKit/gtk/JSCore-1.0.gir 2010-09-10 23:20:33.000000000 +10008--- webkit-1.2.5.orig/WebKit/gtk/JSCore-1.0.gir 2010-09-10 23:20:33.000000000 +1000

Subscribers

People subscribed via source and target branches

to all changes: