Code review comment for lp:~arges/arsenal/arsenal

Revision history for this message
Brian Murray (brian-murray) wrote :

Disregarding the conflicts in collect-bug-data there are a couple of things that could use cleaning up.

The dir(bug) in collect-bug-data seems to be leftover from some debugging. There is also an import of seg from seglib in collect-project-bug-data and seglib isn't part of arsenal as far as I can tell. The 'print pbug_id' looks like it also may be leftover from debugging.

The current convention is also to have mako templates in the web/templates directory so moving the template file there would be great too.

Otherwise, it looks good, thanks!

review: Needs Fixing

« Back to merge proposal