Merge lp:~arand/ubuntu/lucid/pango-graphite/suggested-sru-patch into lp:ubuntu/lucid/pango-graphite

Proposed by Martin Erik Werner
Status: Merged
Approved by: Martin Pitt
Approved revision: 4
Merge reported by: Martin Pitt
Merged at revision: not available
Proposed branch: lp:~arand/ubuntu/lucid/pango-graphite/suggested-sru-patch
Merge into: lp:ubuntu/lucid/pango-graphite
Diff against target: 99 lines (+87/-0)
2 files modified
debian/changelog (+8/-0)
debian/patches/u01_crasher-fix.patch (+79/-0)
To merge this branch: bzr merge lp:~arand/ubuntu/lucid/pango-graphite/suggested-sru-patch
Reviewer Review Type Date Requested Status
Martin Pitt Approve
Review via email: mp+113699@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

Thanks! Uploaded to lucid-proposed queue.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2008-03-22 10:14:24 +0000
+++ debian/changelog 2012-07-06 07:42:32 +0000
@@ -1,3 +1,11 @@
1pango-graphite (0.9.2-3.1ubuntu0.1) lucid; urgency=low
2
3 * Add debian/patches/u01_crasher-fix.patch:
4 Fixes for causing crashes in several applications, including GDM
5 (LP: #540035)
6
7 -- Martin Erik Werner <martinerikwerner@gmail.com> Fri, 06 Jul 2012 00:25:22 +0200
8
1pango-graphite (0.9.2-3.1) unstable; urgency=medium9pango-graphite (0.9.2-3.1) unstable; urgency=medium
210
3 * Non-maintainer upload.11 * Non-maintainer upload.
412
=== added file 'debian/patches/u01_crasher-fix.patch'
--- debian/patches/u01_crasher-fix.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/u01_crasher-fix.patch 2012-07-06 07:42:32 +0000
@@ -0,0 +1,79 @@
1Description: Fixes for causing crashes in several applications
2 This patch consists of all the code changes from pango-graphite v0.9.2 to
3 v0.9.3, with autotools and documentation changes stripped.
4 .
5 The patch was created for an Ubuntu "Stable Release Update" and solves
6 several crashes which pango-graphite caused in other applications, for
7 example GDM.
8Origin: upstream, http://sourceforge.net/projects/silgraphite/files/pango-graphite/0.9.3/pango-graphite-0.9.3.tar.gz
9Bug-Ubuntu: https://launchpad.net/bugs/540035
10Bug-Debian: http://bugs.debian.org/471642
11Forwarded: not-needed
12Last-Update: 2012-07-06
13
14diff -Nurp pango-graphite-0.9.2/graphite-module.c pango-graphite-0.9.3/graphite-module.c
15--- pango-graphite-0.9.2/graphite-module.c 2007-08-27 18:26:02.000000000 +0200
16+++ pango-graphite-0.9.3/graphite-module.c 2008-04-07 09:35:07.000000000 +0200
17@@ -44,7 +44,11 @@ typedef PangoEngineLangClass GraphiteEng
18
19
20 static PangoEngineScriptInfo graphite_scripts[] = {
21+#if (PANGO_MAJOR_VERSION > 1 || PANGO_MINOR_VERSION > 18)
22+ { PANGO_SCRIPT_COMMON, "" }, /* Zyyy */
23+#else
24 { PANGO_SCRIPT_COMMON, "*" }, /* Zyyy */
25+#endif
26 { PANGO_SCRIPT_INHERITED, "*" }, /* Qaai */
27 { PANGO_SCRIPT_ARABIC, "*" }, /* Arab */
28 { PANGO_SCRIPT_ARMENIAN, "*" }, /* Armn */
29diff -Nurp pango-graphite-0.9.2/graphitecache.h pango-graphite-0.9.3/graphitecache.h
30--- pango-graphite-0.9.2/graphitecache.h 2007-08-27 18:26:02.000000000 +0200
31+++ pango-graphite-0.9.3/graphitecache.h 2008-05-09 06:55:52.000000000 +0200
32@@ -25,6 +25,7 @@
33 #include "PangoTextSrc.h"
34 #include "PangoGrFont.h"
35 #include <graphite/Segment.h>
36+#include <graphite/SegmentAux.h>
37
38 using gr::PangoTextSrc;
39 using gr::PangoGrFont;
40diff -Nurp pango-graphite-0.9.2/pangographite.cpp pango-graphite-0.9.3/pangographite.cpp
41--- pango-graphite-0.9.2/pangographite.cpp 2007-08-27 18:26:02.000000000 +0200
42+++ pango-graphite-0.9.3/pangographite.cpp 2008-05-09 06:54:01.000000000 +0200
43@@ -27,6 +27,8 @@
44 typedef std::pair<gr::GlyphIterator, gr::GlyphIterator> GlyphRange;
45 typedef std::pair<gr::GlyphSetIterator, gr::GlyphSetIterator> GrGlyphSet;
46
47+static gr::LayoutEnvironment default_layout;
48+
49 void graphite_PangoLogAttrs(const char *text,
50 int length,
51 PangoFcFont *xftfont,
52@@ -47,13 +49,14 @@ void graphite_PangoLogAttrs(const char
53 }
54
55 RangeSegment *grseg = NULL;
56- grseg = graphite_GetSegment(pTextSrc, pgrFont);
57+ grseg = graphite_GetSegment(pTextSrc, pgrFont);
58 if (!grseg)
59 {
60 try
61 {
62+ default_layout.setDumbFallback(true);
63 pgrFont->lockFace();
64- grseg = new RangeSegment(pgrFont, pTextSrc, NULL, 0, length);
65+ grseg = new RangeSegment(pgrFont, pTextSrc, &default_layout, 0, length);
66 pgrFont->unlockFace();
67 graphite_CacheSegment(pTextSrc, pgrFont, grseg);
68 }
69@@ -187,8 +190,9 @@ void graphite_PangoGlyphString(const cha
70 grseg = graphite_GetSegment(pTextSrc, pgrFont);
71 if (!grseg)
72 {
73+ default_layout.setDumbFallback(true);
74 pgrFont->lockFace();
75- grseg = new RangeSegment(pgrFont, pTextSrc, NULL, 0, length);
76+ grseg = new RangeSegment(pgrFont, pTextSrc, &default_layout, 0, length);
77 pgrFont->unlockFace();
78 graphite_CacheSegment(pTextSrc, pgrFont, grseg);
79 }

Subscribers

People subscribed via source and target branches