Merge lp:~ara/ubuntu-qa-website/bug_488707 into lp:~ubuntu-qa-website-devel/ubuntu-qa-website/trunk

Proposed by Ara Pulido
Status: Merged
Merged at revision: not available
Proposed branch: lp:~ara/ubuntu-qa-website/bug_488707
Merge into: lp:~ubuntu-qa-website-devel/ubuntu-qa-website/trunk
Diff against target: 12 lines (+3/-0)
1 file modified
code/modules/qatracker/qatracker.function.php (+3/-0)
To merge this branch: bzr merge lp:~ara/ubuntu-qa-website/bug_488707
Reviewer Review Type Date Requested Status
Ubuntu QA Website Developers Pending
Review via email: mp+16417@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Ara Pulido (ara) wrote :

Added a new check on post to avoid allowing marking a test as failed, without providing a bug number. It fixes bug 488707.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'code/modules/qatracker/qatracker.function.php'
2--- code/modules/qatracker/qatracker.function.php 2008-03-05 20:45:53 +0000
3+++ code/modules/qatracker/qatracker.function.php 2009-12-21 09:35:22 +0000
4@@ -40,6 +40,9 @@
5 if ((!is_numeric($data['isot_result'])) && ($data['isot_valid'] || $data['isot_addbug'])) {
6 $data['isot_error'].="<font color=\"red\">You must select a result</font><br />";
7 }
8+ if (($data['isot_result'] == 0) && (count($data['isot_bug']) == 0) && ($_SERVER['REQUEST_METHOD'] === 'POST'))
9+ $data['isot_error'].="<font color=\"red\">To mark a test as failed, you need to provide a bug number</font><br />";
10+
11 return $data;
12 }
13

Subscribers

People subscribed via source and target branches

to status/vote changes: