Merge lp:~ara/gwibber/apport_bug_384552 into lp:gwibber/1.2

Proposed by Greg Grossmeier
Status: Rejected
Rejected by: Ken VanDine
Proposed branch: lp:~ara/gwibber/apport_bug_384552
Merge into: lp:gwibber/1.2
Diff against target: None lines
To merge this branch: bzr merge lp:~ara/gwibber/apport_bug_384552
Reviewer Review Type Date Requested Status
Ken VanDine Disapprove
Review via email: mp+10266@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Sorry this took so long to get reviewed, the client has been re-written. The ubuntu package now includes an apport hook.

Thanks for your submission.

review: Disapprove

Unmerged revisions

350. By Ara Pulido

Added ubuntu-bug link to Report A Problem menu. Fixes LP:#384552

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'gwibber/client.py'
--- gwibber/client.py 2009-07-12 20:56:59 +0000
+++ gwibber/client.py 2009-07-13 09:42:48 +0000
@@ -5,7 +5,7 @@
55
6"""6"""
77
8import time, os, threading, logging, mx.DateTime, hashlib8import time, os, threading, logging, mx.DateTime, hashlib, subprocess
9from . import table9from . import table
10import gtk, gtk.glade, gobject, functools, traceback10import gtk, gtk.glade, gobject, functools, traceback
11import microblog11import microblog
@@ -742,6 +742,10 @@
742 key, mod = gtk.accelerator_parse("Escape")742 key, mod = gtk.accelerator_parse("Escape")
743 accelGroup.connect_group(key, mod, gtk.ACCEL_VISIBLE, self.on_cancel_reply)743 accelGroup.connect_group(key, mod, gtk.ACCEL_VISIBLE, self.on_cancel_reply)
744744
745 def report_a_problem():
746 if subprocess.call(['ubuntu-bug', '-p', 'gwibber'], stdout=subprocess.PIPE) != 0:
747 gintegration.load_url("https://bugs.launchpad.net/gwibber/+filebug")
748
745 def create_action(name, accel, stock, fn, parent = menuGwibber):749 def create_action(name, accel, stock, fn, parent = menuGwibber):
746 mi = gtk.Action("gwibber%s" % name, "%s" % name, None, stock)750 mi = gtk.Action("gwibber%s" % name, "%s" % name, None, stock)
747 gtk.accel_map_add_entry("<Gwibber>/%s" % name, *gtk.accelerator_parse(accel))751 gtk.accel_map_add_entry("<Gwibber>/%s" % name, *gtk.accelerator_parse(accel))
@@ -773,7 +777,7 @@
773 actTranslate = gtk.Action("gwibberTranslate", _("Translate This Application..."), None, None)777 actTranslate = gtk.Action("gwibberTranslate", _("Translate This Application..."), None, None)
774 actTranslate.connect("activate", lambda *a: gintegration.load_url("https://translations.launchpad.net/gwibber"))778 actTranslate.connect("activate", lambda *a: gintegration.load_url("https://translations.launchpad.net/gwibber"))
775 actReportProblem = gtk.Action("gwibberReportProblem", _("Report a Problem"), None, None)779 actReportProblem = gtk.Action("gwibberReportProblem", _("Report a Problem"), None, None)
776 actReportProblem.connect("activate", lambda *a: gintegration.load_url("https://bugs.launchpad.net/gwibber/+filebug"))780 actReportProblem.connect("activate", lambda *a: report_a_problem())
777 actAbout = gtk.Action("gwibberAbout", _("_About"), None, gtk.STOCK_ABOUT)781 actAbout = gtk.Action("gwibberAbout", _("_About"), None, gtk.STOCK_ABOUT)
778 actAbout.connect("activate", self.on_about)782 actAbout.connect("activate", self.on_about)
779783

Subscribers

People subscribed via source and target branches