Merge lp:~apw/launchpad/signing-permissions into lp:launchpad
Proposed by
Andy Whitcroft
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 18065 | ||||
Proposed branch: | lp:~apw/launchpad/signing-permissions | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
40 lines (+8/-0) 2 files modified
lib/lp/archivepublisher/signing.py (+3/-0) lib/lp/archivepublisher/tests/test_signing.py (+5/-0) |
||||
To merge this branch: | bzr merge lp:~apw/launchpad/signing-permissions | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Colin Watson (community) | Approve | ||
Review via email: mp+295616@code.launchpad.net |
Commit message
Fix the permissions of newly created Kmod signing x509 certificates.
Description of the change
Fix the permissions of newly created Kmod signing x509 certificates.
This is public information there is no need for them to be private. Make sure these are readable after creation.
To post a comment you must log in.
Could you add a test as well? I think you could reasonably just tack a stat check onto the end of test_create_ kmod_keys_ autokey_ on, and that would also be a good place to check (more importantly) that kmod.pem isn't world-readable.