Code review comment for lp:~appi2012/gnome-activity-journal/bettertheming

Revision history for this message
appi2012 (appi2012) wrote :

This branch contains some coloring fixes, which make gnome-activity-journal look better, especially on dark themes. (Almost) all colors used in this branch are based on the gtk theme, and thus help the app blend in with the system. Also, it uses more versatile code to determine the shaded text colors, such as those used when listing the day part names ("Morning", etc.): instead of saying the color should be 2/3 * the normal fg color, it blends the background and foreground colors, using 1 part fg and 2 parts bg. This way, it results in the current, light gray color on light themes, but changes to match darker themes as well as themes with wacky colors.

The code is fairly simple, and should be easy to apply to the new calendar widget as well (which looks really nice, but it doesnt graph any of the data that gets clumped into a category widget ("4 Read or Edited Code"))

I hope this code helps.

« Back to merge proposal