Merge lp:~apachelogger/software-properties/python-apt-is-like into lp:software-properties

Proposed by Harald Sitter
Status: Needs review
Proposed branch: lp:~apachelogger/software-properties/python-apt-is-like
Merge into: lp:software-properties
Diff against target: 72 lines (+18/-5)
4 files modified
debian/changelog (+10/-0)
debian/control (+1/-1)
softwareproperties/SoftwareProperties.py (+4/-2)
softwareproperties/ppa.py (+3/-2)
To merge this branch: bzr merge lp:~apachelogger/software-properties/python-apt-is-like
Reviewer Review Type Date Requested Status
Michael Vogt Pending
Review via email: mp+310426@code.launchpad.net
To post a comment you must log in.

Unmerged revisions

987. By Harald Sitter

* Use is_like from python-apt to determine whether or not distros
  are compatible. This act as additional constraint to the changes
  introduced in 0.96.24.2 enforcing higher accuracy on whether a
  derivate ought to be considered compatible or not.
  + Bump python-apt requirement to 1.1.0~beta5 to have is_like.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2016-09-23 10:47:57 +0000
+++ debian/changelog 2016-11-09 12:40:49 +0000
@@ -1,3 +1,13 @@
1software-properties (0.96.24.8) UNRELEASED; urgency=medium
2
3 * Use is_like from python-apt to determine whether or not distros
4 are compatible. This act as additional constraint to the changes
5 introduced in 0.96.24.2 enforcing higher accuracy on whether a
6 derivate ought to be considered compatible or not.
7 + Bump python-apt requirement to 1.1.0~beta5 to have is_like.
8
9 -- Harald Sitter <sitter@kde.org> Wed, 09 Nov 2016 13:30:13 +0100
10
1software-properties (0.96.24.7) yakkety; urgency=medium11software-properties (0.96.24.7) yakkety; urgency=medium
212
3 [ Dimitri John Ledkov ]13 [ Dimitri John Ledkov ]
414
=== modified file 'debian/control'
--- debian/control 2016-09-21 11:48:24 +0000
+++ debian/control 2016-11-09 12:40:49 +0000
@@ -31,7 +31,7 @@
31Section: python31Section: python
32Architecture: all32Architecture: all
33Depends: ${python3:Depends}, ${misc:Depends}, python3, python3-apt (>=33Depends: ${python3:Depends}, ${misc:Depends}, python3, python3-apt (>=
34 0.6.20ubuntu16), lsb-release, iso-codes, gnupg, dirmngr34 1.1.0~beta5), lsb-release, iso-codes, gnupg, dirmngr
35Recommends: unattended-upgrades35Recommends: unattended-upgrades
36Description: manage the repositories that you install software from36Description: manage the repositories that you install software from
37 This software provides an abstraction of the used apt repositories.37 This software provides an abstraction of the used apt repositories.
3838
=== modified file 'softwareproperties/SoftwareProperties.py'
--- softwareproperties/SoftwareProperties.py 2016-03-16 09:17:42 +0000
+++ softwareproperties/SoftwareProperties.py 2016-11-09 12:40:49 +0000
@@ -675,7 +675,8 @@
675 /usr/share/app-install/channels or it is a public Launchpad PPA.675 /usr/share/app-install/channels or it is a public Launchpad PPA.
676 """676 """
677 (srcline, _fname) = shortcut.expand(677 (srcline, _fname) = shortcut.expand(
678 codename=self.distro.codename, distro=self.distro.id.lower())678 codename=self.distro.codename, distro=self.distro.id.lower(),
679 distro_is_like=self.distro.is_like)
679 channel = self._is_line_in_whitelisted_channel(srcline)680 channel = self._is_line_in_whitelisted_channel(srcline)
680 if channel:681 if channel:
681 keyp = "%s/%s.key" % (self.CHANNEL_PATH, channel)682 keyp = "%s/%s.key" % (self.CHANNEL_PATH, channel)
@@ -726,7 +727,8 @@
726 """727 """
727728
728 (deb_line, file) = shortcut.expand(729 (deb_line, file) = shortcut.expand(
729 codename=self.distro.codename, distro=self.distro.id.lower())730 codename=self.distro.codename, distro=self.distro.id.lower(),
731 distro_is_like=self.distro.is_like)
730 deb_line = self.expand_http_line(deb_line)732 deb_line = self.expand_http_line(deb_line)
731 debsrc_entry_type = 'deb-src' if enable_source_code else '# deb-src'733 debsrc_entry_type = 'deb-src' if enable_source_code else '# deb-src'
732 debsrc_line = debsrc_entry_type + deb_line[3:]734 debsrc_line = debsrc_entry_type + deb_line[3:]
733735
=== modified file 'softwareproperties/ppa.py'
--- softwareproperties/ppa.py 2016-09-21 20:01:50 +0000
+++ softwareproperties/ppa.py 2016-11-09 12:40:49 +0000
@@ -395,10 +395,11 @@
395 def info(self):395 def info(self):
396 return self._info396 return self._info
397397
398 def expand(self, codename, distro=None):398 def expand(self, codename, distro=None, distro_is_like=[]):
399 if (distro is not None399 if (distro is not None
400 and distro != self._info["distribution"]400 and distro != self._info["distribution"]
401 and not series_valid_for_distro(self._info["distribution"], codename)):401 and not series_valid_for_distro(self._info["distribution"], codename)
402 and not self._info["distribution"] in distro_is_like):
402 # The requested PPA is for a foreign distribution. Guess that403 # The requested PPA is for a foreign distribution. Guess that
403 # the user wants that distribution's current series.404 # the user wants that distribution's current series.
404 # This only applies if the local distribution is not the same405 # This only applies if the local distribution is not the same

Subscribers

People subscribed via source and target branches

to status/vote changes: