Code review comment for lp:~ansharyan015/drizzle/logging_query_dynamic

Revision history for this message
Daniel Nichter (daniel-nichter) wrote :

The new tests have hard-coded paths which fail:

logging_query.file [ fail ]
--- /home/vagrant/drizzle/stage/tests/../plugin/logging_query/tests/r/file.result 2012-07-10 02:00:27.845566000 +0300
+++ /home/vagrant/drizzle/stage/tests/../plugin/logging_query/tests/r/file.reject 2012-07-10 02:14:20.671982823 +0300
@@ -1,49 +1,49 @@
 Log file exists
-1 /home/ansh/repos/drizzle/logging_query_dynamic/tests/var/logging_query.log
+1 /home/vagrant/drizzle/stage/tests/var/logging_query.log
 SHOW VARIABLES LIKE "%logging_query%";
 Variable_name Value
 logging_query_enable OFF
-logging_query_filename /home/ansh/repos/drizzle/logging_query_dynamic/tests/var/logging_query.log
+logging_query_filename /home/vagrant/drizzle/stage/tests/var/logging_query.log
 logging_query_pcre
 logging_query_threshold_big_examined 0
 logging_query_threshold_big_resultset 0
 logging_query_threshold_slow 0
-1 /home/ansh/repos/drizzle/logging_query_dynamic/tests/var/logging_query.log
+1 /home/vagrant/drizzle/stage/tests/var/logging_query.log
 SET GLOBAL logging_query_enable=true;
 SELECT 1;
 1
 1
-3 /home/ansh/repos/drizzle/logging_query_dynamic/tests/var/logging_query.log
+3 /home/vagrant/drizzle/stage/tests/var/logging_query.log
 SET GLOBAL logging_query_pcre="SHOW.+";
 SELECT @@logging_query_enable;
 @@logging_query_enable
 1
-4 /home/ansh/repos/drizzle/logging_query_dynamic/tests/var/logging_query.log
+4 /home/vagrant/drizzle/stage/tests/var/logging_query.log
 SHOW VARIABLES LIKE "%logging_query%";
 Variable_name Value
 logging_query_enable ON
-logging_query_filename /home/ansh/repos/drizzle/logging_query_dynamic/tests/var/logging_query.log
+logging_query_filename /home/vagrant/drizzle/stage/tests/var/logging_query.log
 logging_query_pcre SHOW.+
 logging_query_threshold_big_examined 0
 logging_query_threshold_big_resultset 0
 logging_query_threshold_slow 0
-5 /home/ansh/repos/drizzle/logging_query_dynamic/tests/var/logging_query.log
+5 /home/vagrant/drizzle/stage/tests/var/logging_query.log
 SET GLOBAL logging_query_filename="DRIZZLETEST_VARDIR/logging_query1.log";
-1 /home/ansh/repos/drizzle/logging_query_dynamic/tests/var/logging_query1.log
+1 /home/vagrant/drizzle/stage/tests/var/logging_query1.log
 SELECT @@logging_query_enable;
 @@logging_query_enable
 1
-5 /home/ansh/repos/drizzle/logging_query_dynamic/tests/var/logging_query.log
-1 /home/ansh/repos/drizzle/logging_query_dynamic/tests/var/logging_query1.log
+5 /home/vagrant/drizzle/stage/tests/var/logging_query.log
+1 /home/vagrant/drizzle/stage/tests/var/logging_query1.log
 SHOW VARIABLES LIKE "%logging_query%";
 Variable_name Value
 logging_query_enable ON
-logging_query_filename /home/ansh/repos/drizzle/logging_query_dynamic/tests/var/logging_query1.log
+logging_query_filename /home/vagrant/drizzle/stage/tests/var/logging_query1.log
 logging_query_pcre SHOW.+
 logging_query_threshold_big_examined 0
 logging_query_threshold_big_resultset 0
 logging_query_threshold_slow 0
-5 /home/ansh/repos/drizzle/logging_query_dynamic/tests/var/logging_query.log
-2 /home/ansh/repos/drizzle/logging_query_dynamic/tests/var/logging_query1.log
+5 /home/vagrant/drizzle/stage/tests/var/logging_query.log
+2 /home/vagrant/drizzle/stage/tests/var/logging_query1.log
 SET GLOBAL logging_query_filename="";
 ERROR HY000: Incorrect arguments to SET

review: Needs Fixing (code review)

« Back to merge proposal