Code review comment for lp:~ansharyan015/drizzle/auth_file_dynamic

Revision history for this message
Daniel Nichter (daniel-nichter) wrote :

Overall the changes look godo. There are minor code style changes for later perhaps, like in

bool AuthFile::setUsersFile(std::string& usersFile)

the arg should probably be called "users_file" instead. Similarly, the use of "*_dummy" vars are more clear when named "new_*" (e.g. new_users_file), as was done in regex_policy.

review: Approve (code review)

« Back to merge proposal