review-tools

Merge ~anonymouse67/review-tools:feature/eks-snap-can-use-plugs into review-tools:master

  1. Git
  2. lp:~anonymouse67/review-tools
  3. feature/eks-snap-can-use-plugs
  4. Merge into master
Proposed by Ian Johnson
Status: Merged
Merged at revision: 2f17eca6ec2882d24f02bd79f6bb03792447643a
Proposed branch: ~anonymouse67/review-tools:feature/eks-snap-can-use-plugs
Merge into: review-tools:master
Diff against target: 13 lines (+1/-1)
1 file modified
reviewtools/overrides.py (+1/-1)
Reviewer Review Type Date Requested Status
Alex Murray Approve
Review via email: mp+397309@code.launchpad.net

Commit message

Allow the eks snap to use interfaces while classic.

The eks snap is similar in spirit to the microk8s snap, so allow the eks snap to use interfaces while classic same as microk8s.

Description of the change

Allow the eks snap to use interfaces while classic.

The eks snap is similar in spirit to the microk8s snap, so allow the eks snap to use interfaces while classic same as microk8s.

To post a comment you must log in.
Revision history for this message
Alex Murray (alexmurray) wrote :

LGTM - thanks Ian!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/reviewtools/overrides.py b/reviewtools/overrides.py
2index 1d7d6bd..cf668a5 100644
3--- a/reviewtools/overrides.py
4+++ b/reviewtools/overrides.py
5@@ -131,7 +131,7 @@ desktop_file_exception = ["emoj", "ffscreencast", "pulsemixer"]
6
7 # List of classic snaps that may specify slots/plugs (eg, for workaround
8 # content interface methodology)
9-classic_interfaces_exception = ["certbot", "juju", "microk8s"]
10+classic_interfaces_exception = ["certbot", "juju", "microk8s", "eks"]
11
12 # List additional attributes that a particular snap may specify with a
13 # particular side of a particular interface (eg, for workaround content

Subscribers

People subscribed via source and target branches

to all changes: