Code review comment for lp:~ankatare/juju-ci-tools/juju-aws-add-credential

Revision history for this message
Christopher Lee (veebers) wrote :

Running the tests I get a fail: http://pastebin.ubuntu.com/23855616/
This is related to test_get_aws_credentials_from_file's call to get_aws_credentials_from_file actually trying to read that file but it doesn't actually exist (it might for you on you machine?).
I've included notes on resolving this inline with the test.

I see that tests for changes to jujupy/client.py are still incoming.

review: Needs Fixing

« Back to merge proposal