Code review comment for lp:~angus-akkea/linaro-image-tools/Samsung-SMDKV310

Revision history for this message
Angus Ainslie (angus-akkea) wrote :

Hi Loic,

On Mon, Feb 28, 2011 at 6:59 PM, Loïc Minier <email address hidden> wrote:
>  Note for self: there are a couple of things I would like to do before
>  doing the final merge:
>  * replace "movi read kernel 40007000" with %(kernel_addr), but I don't
>   know whether movi accepts addresses prefixed with 0x

The board still boots fine if those constants are prefixed with '0x'

>  * add tests to some new functions like make_flashable_env(),
>   install_smdkv310_uImage() etc.
>

How would those be tested ? Write them out to a file and then do an md5sum ?

Angus

« Back to merge proposal