Code review comment for lp:~angus-akkea/linaro-image-tools/Samsung-SMDKV310
Revision history for this message
| Angus Ainslie (angus-akkea) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
On Mon, Feb 21, 2011 at 4:55 PM, Loïc Minier <email address hidden> wrote:
> Hi,
>
> @Angus: In lp:~lool/linaro-image-tools/samsung-v310, I've prepared some
> changes on top of lp:~angus-akkea/linaro-image-tools/Samsung-SMDKV310.
> This mainly reworks the partitioning to use just a bootloader partition
> and compute offsets/lengths from a set of constants.
>
> Could you take a look and consider merging it in your own branch? I
> obviously can't test it, but it passes tests.
>
Sure, once I get my new board I'll be looking at the l-m-c code again.
> I have a new question with the current implementation: why dd the first
> and last sectors of your u-boot file separately instead of dd-ing the
> whole file and then replacing the environment?
>
Before I wrote the make_flashable_env method I chose not to overwrite
the env portion of the MMC card.
Angus