Code review comment for ~andyliuliming/cloud-init:reporting

Revision history for this message
Paul Meyer (paul-meyer) wrote :

Here's a patch for the two style fixes that are needed:

diff --git a/cloudinit/reporting/handlers.py b/cloudinit/reporting/handlers.py
index c77bf2d1..e12d8ea8 100644
--- a/cloudinit/reporting/handlers.py
+++ b/cloudinit/reporting/handlers.py
@@ -284,7 +284,8 @@ class HyperVKvpReportingHandler(ReportingHandler):
                 try:
                     if not os.path.exists(self._kvp_file_path):
                         LOG.warning(
- "skip writing event %s to %s because file not exists.",
+ "skip writing event %s to %s because " +
+ "file not exists.",
                             event.as_string(),
                             self._kvp_file_path)
                     encoded_event = self._encode_event(event)
diff --git a/tests/unittests/test_reporting_hyperv.py b/tests/unittests/test_reporting_hyperv.py
index 0b62506a..2e64c6c7 100644
--- a/tests/unittests/test_reporting_hyperv.py
+++ b/tests/unittests/test_reporting_hyperv.py
@@ -5,7 +5,6 @@ from cloudinit.reporting import handlers

 import json
 import os
-import tempfile

 from cloudinit import util
 from cloudinit.tests.helpers import CiTestCase

« Back to merge proposal