Merge lp:~andrzejtp2010/lightdm/lightdm-trunk-xephyr-multiseat into lp:lightdm
Status: | Rejected |
---|---|
Rejected by: | Robert Ancell |
Proposed branch: | lp:~andrzejtp2010/lightdm/lightdm-trunk-xephyr-multiseat |
Merge into: | lp:lightdm |
Diff against target: |
72 lines (+19/-1) 3 files modified
src/lightdm.c (+2/-0) src/vt.c (+8/-0) src/xserver-local.c (+9/-1) |
To merge this branch: | bzr merge lp:~andrzejtp2010/lightdm/lightdm-trunk-xephyr-multiseat |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Ancell | Disapprove | ||
Review via email: mp+120286@code.launchpad.net |
Description of the change
Dear All,
There are 2 patches proposed for merging, and they add the following:
- On closing an xserver-local remove the corresponding lock file from the temporary directory; stale files impact the choice of DISPLAY numbers in subsequent runs of lightdm
- Optionally use the same vt number for all seats
These changes are required for xephyr-based multiseat configuration to work. Please see beforeafterx.
The first patch is a cleanup useful for all use cases. The second patch by default does not change the already existing behaviour so it won't hurt.
I kindly ask for a review,
Andrzej
Unmerged revisions
- 1536. By Andrzej Pietrasiewicz
-
Optionally use a common vt number for each seat, FALSE by default.
- 1535. By Andrzej Pietrasiewicz
-
Unlink lock file in the temporary directory on stopped_cb
Hi Andrzej,
The first change of removing the lock file is the wrong thing to do. The lock file is owned by the X server process and should only be removed by the X server in question. What is the reason for this change?
The second change of using a common VT doesn't seem required. As far as I can tell Xephyr ignores the VT option (as it's not required) so I don't see a need for this.