Code review comment for lp:~andrewsomething/ubuntu-packaging-guide/i18n

Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

On Fri, Mar 16, 2012 at 12:39 PM, Daniel Holbach
<email address hidden> wrote:
> Review: Needs Information
>
> Thanks a lot for your work on this. This is a great start.
>
> We seem to have a new directory structure like
>
>  /usr/share/doc/ubuntu-packaging-guide/html/en/packaging-new-software.html
>
> now. It looks like we will just have to live with it (Updated bookmarks, etc.)

I like keeping the orderly structure of:

 /usr/share/doc/ubuntu-packaging-guide/html/$lang/

But I guess there's no reason we can't put the English version
directly in html/ and just use html/$lang/ for other languages. I'll
push a new revision.

> Also did I notice
>  /usr/share/doc/ubuntu-packaging-guide/html/en/_static/minus.png
> which looks like we'll have lots of duplicate files. I can't quite remember which technology we used to replace it with symlinks.

There's probably a few ways we can do this. Since we're already
processing stuff with sed, maybe we could just make the links in the
html to html/$lang/_static/ all point to html/_static and share the
folder rather than symlinking?

-- Andrew Starr-Bochicchio

   Ubuntu Developer <https://launchpad.net/~andrewsomething>
   Debian Maintainer
<http://qa.debian.org/developer.php?login=a.starr.b%40gmail.com>
   PGP/GPG Key ID: D53FDCB1

« Back to merge proposal