Pressflow

Code review comment for lp:~andrewberry/pressflow/529252-has-js-cookie

  1. 529252-has-js-cookie
  2. Merge into 6
Revision history for this message
mkalkbrenner (markus-kalkbrenner) wrote :

What happens after the user logs out? Shouldn't the cookie be deleted?

Why don't we set the cookie for anonymous users as well like drupal does?

AFAIK the feature has been removed from pressflow to allow varnish to cache pages for anonymous users. They are destinguished form authenticated users using the session cookie and the "HTTP-Vary-Cookie-Header". But I think that varnish could simply be configured to ignore the has_js-cookie like most people already do for google analytics cookies.

« Back to merge proposal