Code review comment for ~andrew.sh/unity:fix-auth-failure-lp1733557
Revision history for this message
| Andrea Azzarone (azzar1) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
I took a look at the code and I think the best way to fix this bug is to make sure that we deal properly with failures in pam_authenticate. This function can:
- succeed because the user entered the correct password
- fail because the user entered the wrong password
- fail because the module failed to start
Right now the third case is not considered. We should emit start_failed signal in this case. Let me know if you want to rewrite the patch otherwise I'll try to do it by the end of the week.