Merge lp:~andreserl/maas/maintain_squiddebproxy_compat into lp:~maas-maintainers/maas/packaging

Proposed by Andres Rodriguez
Status: Merged
Approved by: Andres Rodriguez
Approved revision: 308
Merged at revision: 308
Proposed branch: lp:~andreserl/maas/maintain_squiddebproxy_compat
Merge into: lp:~maas-maintainers/maas/packaging
Diff against target: 50 lines (+16/-0)
4 files modified
debian/extras/99-maas (+5/-0)
debian/maas-region-controller-min.install (+1/-0)
debian/maas-region-controller-min.postrm (+5/-0)
debian/maas-region-controller.postrm (+5/-0)
To merge this branch: bzr merge lp:~andreserl/maas/maintain_squiddebproxy_compat
Reviewer Review Type Date Requested Status
Newell Jensen (community) Approve
Review via email: mp+235671@code.launchpad.net

Commit message

Continue to install squid-deb-proxy extra conf and remove it on postrm for upgrades that continue to use squid-deb-proxy

To post a comment you must log in.
Revision history for this message
Newell Jensen (newell-jensen) wrote :

LGTM. One thing is that a symlink is not a directory so I don't think you need the `r` in the `-rf` part of the command. Don't forget to set a commit message.

review: Approve
Revision history for this message
Newell Jensen (newell-jensen) wrote :

> LGTM. One thing is that a symlink is not a directory so I don't think you
> need the `r` in the `-rf` part of the command. Don't forget to set a commit
> message.

I have been advised that the packaging branches have to be done manually so not commit message needed.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'debian/extras/99-maas'
2--- debian/extras/99-maas 1970-01-01 00:00:00 +0000
3+++ debian/extras/99-maas 2014-09-23 16:32:16 +0000
4@@ -0,0 +1,5 @@
5+# /etc/squid-deb-proxy/mirror-dstdomain.acl.d/99-maas
6+#
7+# Enable launchpad personal package archives for squid-deb-proxy
8+ppa.launchpad.net
9+keyserver.ubuntu.com
10
11=== modified file 'debian/maas-region-controller-min.install'
12--- debian/maas-region-controller-min.install 2014-09-19 18:35:51 +0000
13+++ debian/maas-region-controller-min.install 2014-09-23 16:32:16 +0000
14@@ -41,3 +41,4 @@
15 debian/extras/maas-region-celeryd usr/sbin
16 debian/extras/20-maas.conf etc/rsyslog.d
17 debian/extras/maas_remote_syslog_compress etc/cron.d
18+debian/extras/99-maas usr/share/maas/conf
19
20=== modified file 'debian/maas-region-controller-min.postrm'
21--- debian/maas-region-controller-min.postrm 2014-09-12 19:10:04 +0000
22+++ debian/maas-region-controller-min.postrm 2014-09-23 16:32:16 +0000
23@@ -28,6 +28,11 @@
24 invoke-rc.d apache2 restart || true
25 fi
26
27+ # Delete symlink
28+ if [ -L /etc/squid-deb-proxy/mirror-dstdomain.acl.d/99-maas ]; then
29+ rm -rf /etc/squid-deb-proxy/mirror-dstdomain.acl.d/99-maas
30+ fi
31+
32 # Delete any remaining / leftover file
33 rm -rf /usr/share/maas/maas/
34 esac
35
36=== modified file 'debian/maas-region-controller.postrm'
37--- debian/maas-region-controller.postrm 2014-09-12 19:10:04 +0000
38+++ debian/maas-region-controller.postrm 2014-09-23 16:32:16 +0000
39@@ -35,6 +35,11 @@
40 invoke-rc.d apache2 restart || true
41 fi
42
43+ # Delete symlink
44+ if [ -L /etc/squid-deb-proxy/mirror-dstdomain.acl.d/99-maas ]; then
45+ rm -rf /etc/squid-deb-proxy/mirror-dstdomain.acl.d/99-maas
46+ fi
47+
48 # Remove rabbitmq/longpoll/celery
49 longpoll_user="maas_longpoll"
50 longpoll_vhost="/maas_longpoll"

Subscribers

People subscribed via source and target branches

to all changes: