Code review comment for lp:~andreserl/maas/maas_tftppath_lp1042877

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

I suspect the root problem is that different teams come into this with different operating procedures. We in Red Squad are used to running tests before & after any change, and running the full test suite at least before & after landing — but there's really no point doing that for packaging changes, changes to the client-side packages etc... which is the kind of work that the server team has been doing. In this case, the unfortunate circumstance was that Andres normally has no need to do this (and this _looked_ like a mere configuration change that might not affect tests) whereas Julian would normally expect the engineer to have ensured that tests run before review.

Also, our Jenkins setup must definitely be broken. We should have received emails screaming about this.

« Back to merge proposal