Merge lp:~andreserl/maas/backport_rev_3397_lp1394382 into lp:maas/1.7

Proposed by Andres Rodriguez
Status: Merged
Approved by: Andres Rodriguez
Approved revision: no longer in the source branch.
Merged at revision: 3318
Proposed branch: lp:~andreserl/maas/backport_rev_3397_lp1394382
Merge into: lp:maas/1.7
Diff against target: 41 lines (+22/-5)
1 file modified
src/provisioningserver/drivers/hardware/virsh.py (+22/-5)
To merge this branch: bzr merge lp:~andreserl/maas/backport_rev_3397_lp1394382
Reviewer Review Type Date Requested Status
Andres Rodriguez (community) Approve
Review via email: mp+244352@code.launchpad.net

Commit message

Backport rev 3395 maas does not know about VM paused state

To post a comment you must log in.
Revision history for this message
Andres Rodriguez (andreserl) wrote :

self approve.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/provisioningserver/drivers/hardware/virsh.py'
--- src/provisioningserver/drivers/hardware/virsh.py 2014-12-08 16:50:57 +0000
+++ src/provisioningserver/drivers/hardware/virsh.py 2014-12-10 20:43:23 +0000
@@ -33,6 +33,24 @@
33class VirshVMState:33class VirshVMState:
34 OFF = "shut off"34 OFF = "shut off"
35 ON = "running"35 ON = "running"
36 NO_STATE = "no state"
37 IDLE = "idle"
38 PAUSED = "paused"
39 IN_SHUTDOWN = "in shutdown"
40 CRASHED = "crashed"
41 PM_SUSPENDED = "pmsuspended"
42
43
44VM_STATE_TO_POWER_STATE = {
45 VirshVMState.OFF: "off",
46 VirshVMState.ON: "on",
47 VirshVMState.NO_STATE: "off",
48 VirshVMState.IDLE: "off",
49 VirshVMState.PAUSED: "off",
50 VirshVMState.IN_SHUTDOWN: "on",
51 VirshVMState.CRASHED: "off",
52 VirshVMState.PM_SUSPENDED: "off",
53 }
3654
3755
38class VirshError(Exception):56class VirshError(Exception):
@@ -243,8 +261,7 @@
243 if state is None:261 if state is None:
244 raise VirshError('Failed to get domain: %s' % machine)262 raise VirshError('Failed to get domain: %s' % machine)
245263
246 if state == VirshVMState.OFF:264 try:
247 return 'off'265 return VM_STATE_TO_POWER_STATE[state]
248 elif state == VirshVMState.ON:266 except KeyError:
249 return 'on'267 raise VirshError('Unknown state: %s' % state)
250 raise VirshError('Unknown state: %s' % state)

Subscribers

People subscribed via source and target branches

to all changes: