Merge ~andreserl/maas:lp1715230 into maas:master

[Andres Rodriguez]

LP: #1715230 - Fix API endpoint url for volume-groups and partitions

See https://bugs.launchpad.net/maas/+bug/1715230/comments/1 for insight.

While this is a simple change, I think this would break API backward compatibility. Thoughts?

[Blake Rouse (blake-rouse)]

Yes this would break compatibility. It would be an easy fix on the client-side, libmaas would handle it automatically, so might be acceptable.

[Lee Trager (ltrager)]

Why not update the URL and have the old URLs redirect[1]? This would fix the bug while not breaking anyone.

[1] https://docs.djangoproject.com/en/dev/ref/class-based-views/base/#redirectview

review: Needs Information

[MAAS Lander (maas-lander)]

UNIT TESTS
-b lp1715230 lp:~andreserl/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci-jenkins.internal:8080/job/maas/job/branch-tester/4064/console
COMMIT: bc7ed664e97d60bd14ec942539c9b57ccd16217e

review: Needs Fixing

Unmerged commits

bc7ed66... by Andres Rodriguez on 2018-09-25

LP: #1715230 - Fix URL for API endpoints

diff --git a/src/maasserver/urls_api.py b/src/maasserver/urls_api.py
index b71e98a..8b21540 100644
--- a/src/maasserver/urls_api.py
+++ b/src/maasserver/urls_api.py
@@ -360,11 +360,11 @@ urlpatterns += [
         '(?P<device_id>[^/]+)/partitions/$',
         partitions_handler, name='partitions_handler'),
     url(r'^nodes/(?P<system_id>[^/]+)/blockdevices/'
-        '(?P<device_id>[^/]+)/partition/(?P<id>[^/]+)$',
+        '(?P<device_id>[^/]+)/partitions/(?P<id>[^/]+)$',
         partition_handler, name='partition_handler'),
     url(r'^nodes/(?P<system_id>[^/]+)/volume-groups/$',
         volume_groups_handler, name='volume_groups_handler'),
-    url(r'^nodes/(?P<system_id>[^/]+)/volume-group/'
+    url(r'^nodes/(?P<system_id>[^/]+)/volume-groups/'
         '(?P<id>[^/]+)/$',
         volume_group_handler, name='volume_group_handler'),
     url(r'^nodes/(?P<system_id>[^/]+)/raids/$',