Merge ~andreserl/maas:install_kvm into maas:master

[Andres Rodriguez]

This branch is just some initial code to actually install kvm to the machine. This branch doesnt handle:

1. adding the machine as a pod once deployed.
2. figuring out ssh keys (e.g. maas should create a ssh key for itself, and inject it to the deployed machine).
3. Removing the machine from the listing page and/or preventing from it being released. (we should track that a machine was deployed as a pod to not allow the release without confirmation or automatically lock it)./

Unmerged commits

53ae52e... by Andres Rodriguez on 2018-09-04

Initial work to install kvm

2bb405d... by Andres Rodriguez on 2018-09-01

Fix tests which was cuasing infinite loop

6a8f245... by Andres Rodriguez on 2018-08-31

Fix lint

18a37f5... by Andres Rodriguez on 2018-08-31

LP: #1790015 - Fix no_proxy to also use IPv6 addresses inside brackets.

diff --git a/src/maasserver/api/machines.py b/src/maasserver/api/machines.py
index 9a95cc8..31c12fe 100644
--- a/src/maasserver/api/machines.py
+++ b/src/maasserver/api/machines.py
@@ -556,6 +556,9 @@ class MachineHandler(NodeHandler, OwnerDataMixin, PowerMixin):
         :param install_rackd: If True, the Rack Controller will be installed on
             this machine.
         :type install_rackd: boolean
+        :param install_kvm: If True, KVM will be installed on this machine and
+            added to MAAS.
+        :type install_kvm: boolean
 
         Ideally we'd have MIME multipart and content-transfer-encoding etc.
         deal with the encapsulation of binary data, but couldn't make it work
@@ -573,6 +576,8 @@ class MachineHandler(NodeHandler, OwnerDataMixin, PowerMixin):
         hwe_kernel = request.POST.get('hwe_kernel', None)
         install_rackd = get_optional_param(
             request.POST, 'install_rackd', default=False, validator=StringBool)
+        install_kvm = get_optional_param(
+            request.POST, 'install_kvm', default=False, validator=StringBool)
         # Acquiring a node requires VIEW permissions.
         machine = self.model.objects.get_node_or_404(
             system_id=system_id, user=request.user,
@@ -603,6 +608,10 @@ class MachineHandler(NodeHandler, OwnerDataMixin, PowerMixin):
         if (install_rackd and not
                 request.user.has_perm(NODE_PERMISSION.ADMIN, machine)):
             raise PermissionDenied()
+        # Deploying with 'install_kvm' requires ADMIN permissions.
+        if (install_kvm and not
+                request.user.has_perm(NODE_PERMISSION.ADMIN, machine)):
+            raise PermissionDenied()
         if not machine.distro_series and not series:
             series = Config.objects.get_config('default_distro_series')
         Form = get_machine_edit_form(request.user)
@@ -615,6 +624,8 @@ class MachineHandler(NodeHandler, OwnerDataMixin, PowerMixin):
             form.set_hwe_kernel(hwe_kernel=hwe_kernel)
         if install_rackd:
             form.set_install_rackd(install_rackd=install_rackd)
+        if install_kvm:
+            form.set_install_rackd(install_kvm=install_kvm)
         if form.is_valid():
             form.save()
         else:
diff --git a/src/maasserver/forms/__init__.py b/src/maasserver/forms/__init__.py
index 69440fa..9ad9129 100644
--- a/src/maasserver/forms/__init__.py
+++ b/src/maasserver/forms/__init__.py
@@ -842,6 +842,11 @@ class MachineForm(NodeForm):
         self.is_bound = True
         self.data['install_rackd'] = install_rackd
 
+    def set_install_kvm(self, install_kvm=False):
+        """Sets whether to deploy the rack alongside this machine."""
+        self.is_bound = True
+        self.data['install_kvm'] = install_kvm
+
     class Meta:
         model = Machine
 
@@ -853,6 +858,7 @@ class MachineForm(NodeForm):
             'min_hwe_kernel',
             'hwe_kernel',
             'install_rackd',
+            'install_kvm',
         )
 
 
diff --git a/src/maasserver/models/node.py b/src/maasserver/models/node.py
index b09d0dc..977e4b2 100644
--- a/src/maasserver/models/node.py
+++ b/src/maasserver/models/node.py
@@ -864,6 +864,8 @@ class Node(CleanSave, TimestampedModel):
     :ivar objects: The :class:`GeneralManager`.
     :ivar install_rackd: An optional flag to indicate if this node should be
         deployed with the rack controller.
+    :ivar install_kvm: An optional flag to indicate if this node should be
+        deployed with KVM and added to MAAS.
     :ivar enable_ssh: An optional flag to indicate if this node can have
         ssh enabled during commissioning, allowing the user to ssh into the
         machine's commissioning environment using the user's SSH key.
@@ -1046,6 +1048,9 @@ class Node(CleanSave, TimestampedModel):
     # Used to deploy the rack controller on a installation machine.
     install_rackd = BooleanField(default=False)
 
+    # Used to deploy the rack controller on a installation machine.
+    install_kvm = BooleanField(default=False)
+
     # Used to determine whether to:
     #  1. Import the SSH Key during commissioning and keep power on.
     #  2. Skip reconfiguring networking when a node is commissioned.
@@ -2957,6 +2962,7 @@ class Node(CleanSave, TimestampedModel):
         self.hwe_kernel = None
         self.current_installation_script_set = None
         self.install_rackd = False
+        self.install_kvm = False
         self.save()
 
         # Clear the nodes acquired filesystems.
diff --git a/src/maasserver/preseed.py b/src/maasserver/preseed.py
index e795f96..2e2eab6 100644
--- a/src/maasserver/preseed.py
+++ b/src/maasserver/preseed.py
@@ -497,6 +497,12 @@ def get_curtin_config(request, node):
     if 's390x' in node.architecture:
         command = {'maas_00': 'chreipl node /dev/' + node.get_boot_disk().name}
         config['late_commands'].update(command)
+    # TODO: Add commands that install and configure KVM for MAAS' KVM Pod
+    # Customizations are needed for the different architectures. See qa-lab-tests
+    # to determine how to do it.
+    if node.install_kvm:
+        command = {'kmv_pod': 'apt-get install qemu-kvm'}
+        config['late_commands'].update(command)
     return yaml.safe_dump(config)
 
 
diff --git a/src/maasserver/websockets/handlers/device.py b/src/maasserver/websockets/handlers/device.py
index c3cf5c1..4c964a8 100644
--- a/src/maasserver/websockets/handlers/device.py
+++ b/src/maasserver/websockets/handlers/device.py
@@ -131,6 +131,7 @@ class DeviceHandler(NodeHandler):
             "last_image_sync",
             "default_user",
             "install_rackd",
+            "install_kvm",
             ]
         list_fields = [
             "id",
diff --git a/src/maasserver/websockets/handlers/machine.py b/src/maasserver/websockets/handlers/machine.py
index 244ae66..5bb677b 100644
--- a/src/maasserver/websockets/handlers/machine.py
+++ b/src/maasserver/websockets/handlers/machine.py
@@ -172,6 +172,7 @@ class MachineHandler(NodeHandler):
             "managing_process",
             "last_image_sync",
             "install_rackd",
+            "install_kvm",
         ]
         list_fields = [
             "id",