Code review comment for ~andreserl/maas:lp1783889_smartctl

Thanks for the quick response, i appreciate you taking the time to discuss this. In the current implementation we explicitly ignore return code 4, which means that "Some SMART or other ATA command to the disk failed, or there was a checksum error in a SMART data structure". In this scenario we also have no way of knowing in which status the disk is. If we want to be consistent here and give the user a warning if we can not ensure the disk is fine, we should also remove this exception. Since i think removing this would be very inconvenient for all the users that have disks that are not smartctl compatible, i think we should not do this. From my current understanding the return code 64 means that there are errors in the logs, but the current check was fine. If the current check would have failed, the return code would either be 8 or 72 (please correct me if i am wrong here, i have only read the man pages for smartctl). I totally understand that it is important to let the user know when disks are failing, but i think the current implementation is very inconvenient for disks that have had an error a long time ago (which is pretty common during the lifetime of an SSD, but nothing to worry about).