MAAS

Code review comment for ~andreserl/maas:2.3_machine_stats

  1. Git
  2. lp:~andreserl/maas
  3. 2.3_machine_stats
  4. Merge into 2.3
Revision history for this message
Mike Pontillo (mpontillo) wrote :

So this failed to land in a new and interesting way compared to the off-by-one in this code that I just did the drive-by fix for earlier today (which should also be backported).

https://paste.ubuntu.com/p/XkWZSGYKm3/

It seems this is happening because the test is comparing the JSON *string*, and for whatever reason the version of Python in MAAS 2.3 isn't outputting the JSON fields in the same order!

I would suggest fixing this per the inline comment below (and also backporting the off-by-one fix).

review: Needs Fixing

« Back to merge proposal