Merge ~andreserl/maas:drop_python2_deps into maas:master

Proposed by Andres Rodriguez
Status: Rejected
Rejected by: Adam Collard
Proposed branch: ~andreserl/maas:drop_python2_deps
Merge into: maas:master
Diff against target: 28 lines (+3/-15)
1 file modified
required-packages/dev (+3/-15)
Reviewer Review Type Date Requested Status
Björn Tillenius Needs Fixing
Alberto Donato (community) Approve
MAAS Lander Needs Fixing
Review via email: mp+339435@code.launchpad.net

Commit message

Drop python2 deps from devenv.

To post a comment you must log in.
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b drop_python2_deps lp:~andreserl/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci-jenkins.internal:8080/job/maas/job/branch-tester/1715/console
COMMIT: 816d428918c02a689c1c0c2bffc3ac9a14e42faf

review: Needs Fixing
Revision history for this message
Alberto Donato (ack) wrote :

+1

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNABLE TO START LANDING

STATUS: MISSING COMMIT MESSAGE

Revision history for this message
MAAS Lander (maas-lander) wrote :
Revision history for this message
Alberto Donato (ack) :
review: Needs Fixing
Revision history for this message
Alberto Donato (ack) wrote :

actually let's land this as it is, we can fix it later

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :
Revision history for this message
MAAS Lander (maas-lander) wrote :
Revision history for this message
MAAS Lander (maas-lander) wrote :
Revision history for this message
MAAS Lander (maas-lander) wrote :
Revision history for this message
MAAS Lander (maas-lander) wrote :
Revision history for this message
Björn Tillenius (bjornt) wrote :

Most of those python2 packages are needed by the test suite still. We still claim to support upgrading from older versions of MAAS that used south, and which needs python2.

I'm guessing that we could remove the south migrations now, though, since anyone with such old version still have go through xenial to upgrade, and the xenial version would handle the south migrations (at least in theory).

But without removing the south migrations, this branch can't land. FWIW, this is the test failure:

======================================================================
FAIL: maasserver.management.commands.tests.test_dbupgrade.TestDBUpgrade.test_dbu
pgrade_with_always_south ----------------------------------------------------------------------
Traceback (most recent call last):
testtools.testresult.real._StringException: Empty attachments:
  Twisted logs

stdout/err from `/home/bjorn/projects/maas/bin/maas-region dbupgrade --settings
maasserver.djangosettings.settings --always-south`: {{{
Traceback (most recent call last):
  File "/tmp/maas-upgrade-dxf3t0m0/migrate.py", line 70, in <module>
    settings.INSTALLED_APPS += (
  File "/tmp/maas-upgrade-dxf3t0m0/django/conf/__init__.py", line 54, in __getat
tr__
    self._setup(name)
  File "/tmp/maas-upgrade-dxf3t0m0/django/conf/__init__.py", line 49, in _setup
    self._wrapped = Settings(settings_module) File "/tmp/maas-upgrade-dxf3t0m0/django/conf/__init__.py", line 132, in __init
__
    % (self.SETTINGS_MODULE, e)
ImportError: Could not import settings 'maas19settings' (Is it on sys.path? Is t
here an import error in the settings file?): No module named twisted.application
.service
}}}

review: Needs Fixing

Unmerged commits

816d428... by Andres Rodriguez

Cleanup devenv packages

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/required-packages/dev b/required-packages/dev
2index 59490d0..4d389e4 100644
3--- a/required-packages/dev
4+++ b/required-packages/dev
5@@ -19,20 +19,8 @@ make
6 psmisc
7 python3-django-nose
8 python3-dnspython
9-python-bson
10-python-crochet
11-python-django
12-python-django-piston
13-python-djorm-ext-pgarray
14-python-formencode
15-python-lxml
16-python-netaddr
17-python-netifaces
18-python-pocket-lint
19-python-psycopg2
20-python-simplejson
21-python-tempita
22-python-twisted
23-python-yaml
24+python3-djorm-ext-pgarray
25+python3-pocket-lint
26+python3-simplejson
27 socat
28 xvfb

Subscribers

People subscribed via source and target branches