Merge ~andreserl/maas:lp1585841_add_zfs into maas:master

Proposed by Andres Rodriguez
Status: Merged
Approved by: Andres Rodriguez
Approved revision: 583c4d33c35b16c42cbb5b8ff97d4d7225b12eea
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~andreserl/maas:lp1585841_add_zfs
Merge into: maas:master
Diff against target: 59 lines (+28/-0)
2 files modified
src/maasserver/enum.py (+5/-0)
src/maasserver/migrations/builtin/maasserver/0144_filesystem_zfsroot_support.py (+23/-0)
Reviewer Review Type Date Requested Status
MAAS Lander Needs Fixing
Blake Rouse (community) Approve
Newell Jensen (community) Approve
Review via email: mp+336638@code.launchpad.net

Commit message

LP: #1585841 - Add 'zfs' support as a filesystem option.

Description of the change

This is dependent on [1]. Initial discussion was that MAAS was not to make any changes other than add an additional filesystem option, which curtin would handle and create zfs root.

MAAS needs to surface this as experimental.

[1]: https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/335478

To post a comment you must log in.
Revision history for this message
Newell Jensen (newell-jensen) wrote :

LGTM +1

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b lp1585841_add_zfs lp:~andreserl/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci-jenkins.internal:8080/job/maas/job/branch-tester/1326/console
COMMIT: d91aa001d9243d33f8fe63566eb2631fca9fc463

review: Needs Fixing
Revision history for this message
Ryan Harper (raharper) wrote :

I think we can make this work. In this branch, we key off of fstype: 'zfsroot' to indicate that we want to do a zfsroot filesystem.

https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/336723

Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b lp1585841_add_zfs lp:~andreserl/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci-jenkins.internal:8080/job/maas/job/branch-tester/1369/console
COMMIT: 7f21378e7f4a47db563c7c14f732306317b4512b

review: Needs Fixing
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b lp1585841_add_zfs lp:~andreserl/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci-jenkins.internal:8080/job/maas/job/branch-tester/1392/console
COMMIT: a264d3f89173e7a8f6130f54a6a1fb02a6de5186

review: Needs Fixing
Revision history for this message
Blake Rouse (blake-rouse) wrote :

Looks good

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b lp1585841_add_zfs lp:~andreserl/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci-jenkins.internal:8080/job/maas/job/branch-tester/1452/console
COMMIT: 583c4d33c35b16c42cbb5b8ff97d4d7225b12eea

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/maasserver/enum.py b/src/maasserver/enum.py
2index c97b0cd..e823380 100644
3--- a/src/maasserver/enum.py
4+++ b/src/maasserver/enum.py
5@@ -513,6 +513,9 @@ class FILESYSTEM_TYPE:
6 #: BTRFS
7 BTRFS = "btrfs"
8
9+ #: ZFS
10+ ZFSROOT = "zfsroot"
11+
12
13 # Django choices for FILESYSTEM_TYPE: sequence of tuples (key, UI
14 # representation).
15@@ -533,6 +536,7 @@ FILESYSTEM_TYPE_CHOICES = (
16 (FILESYSTEM_TYPE.RAMFS, "ramfs"),
17 (FILESYSTEM_TYPE.TMPFS, "tmpfs"),
18 (FILESYSTEM_TYPE.BTRFS, "btrfs"),
19+ (FILESYSTEM_TYPE.ZFSROOT, "zfsroot"),
20 )
21
22
23@@ -551,6 +555,7 @@ FILESYSTEM_FORMAT_TYPE_CHOICES = (
24 (FILESYSTEM_TYPE.RAMFS, "ramfs"),
25 (FILESYSTEM_TYPE.TMPFS, "tmpfs"),
26 (FILESYSTEM_TYPE.BTRFS, "btrfs"),
27+ (FILESYSTEM_TYPE.ZFSROOT, "zfsroot"),
28 )
29
30
31diff --git a/src/maasserver/migrations/builtin/maasserver/0144_filesystem_zfsroot_support.py b/src/maasserver/migrations/builtin/maasserver/0144_filesystem_zfsroot_support.py
32new file mode 100644
33index 0000000..6fde3ab
34--- /dev/null
35+++ b/src/maasserver/migrations/builtin/maasserver/0144_filesystem_zfsroot_support.py
36@@ -0,0 +1,23 @@
37+# -*- coding: utf-8 -*-
38+# Generated by Django 1.11.9 on 2018-02-07 15:26
39+from __future__ import unicode_literals
40+
41+from django.db import (
42+ migrations,
43+ models,
44+)
45+
46+
47+class Migration(migrations.Migration):
48+
49+ dependencies = [
50+ ('maasserver', '0143_blockdevice_firmware'),
51+ ]
52+
53+ operations = [
54+ migrations.AlterField(
55+ model_name='filesystem',
56+ name='fstype',
57+ field=models.CharField(choices=[('ext2', 'ext2'), ('ext4', 'ext4'), ('xfs', 'xfs'), ('fat32', 'fat32'), ('vfat', 'vfat'), ('lvm-pv', 'lvm'), ('raid', 'raid'), ('raid-spare', 'raid-spare'), ('bcache-cache', 'bcache-cache'), ('bcache-backing', 'bcache-backing'), ('swap', 'swap'), ('ramfs', 'ramfs'), ('tmpfs', 'tmpfs'), ('btrfs', 'btrfs'), ('zfsroot', 'zfsroot')], default='ext4', max_length=20),
58+ ),
59+ ]

Subscribers

People subscribed via source and target branches