Merge ~andreserl/maas:lp1718209 into maas:master

Proposed by Andres Rodriguez
Status: Merged
Approved by: Andres Rodriguez
Approved revision: 1db0a205f099e7249100e7b07ba61f1439f668e7
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~andreserl/maas:lp1718209
Merge into: maas:master
Diff against target: 27 lines (+3/-2)
2 files modified
src/provisioningserver/dhcp/config.py (+2/-1)
src/provisioningserver/templates/dhcp/dhcpd6.conf.template (+1/-1)
Reviewer Review Type Date Requested Status
Mike Pontillo (community) Approve
Review via email: mp+331076@code.launchpad.net

Commit message

LP: #1718209 - Fix IPv6 DHCP PXE configuration.

To post a comment you must log in.
Revision history for this message
Mike Pontillo (mpontillo) wrote :

Looks good. Needs a commit message / bug link though.

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/provisioningserver/dhcp/config.py b/src/provisioningserver/dhcp/config.py
2index 024a17e..160d30d 100644
3--- a/src/provisioningserver/dhcp/config.py
4+++ b/src/provisioningserver/dhcp/config.py
5@@ -47,7 +47,8 @@ logger = logging.getLogger(__name__)
6 # Used to generate the conditional bootloader behaviour
7 CONDITIONAL_BOOTLOADER = ("""
8 {{if ipv6}}
9- {{behaviour}} client-arch-type = {{arch_octet}} {
10+ {{behaviour}} exists dhcp6.client-arch-type and
11+ option dhcp6.client-arch-type = {{arch_octet}} {
12 option dhcp6.bootfile-url \"{{url}}\";
13 }
14 {{else}}
15diff --git a/src/provisioningserver/templates/dhcp/dhcpd6.conf.template b/src/provisioningserver/templates/dhcp/dhcpd6.conf.template
16index b1e33f3..e7b2394 100644
17--- a/src/provisioningserver/templates/dhcp/dhcpd6.conf.template
18+++ b/src/provisioningserver/templates/dhcp/dhcpd6.conf.template
19@@ -2,7 +2,7 @@
20 # overwrite any changes made there. Instead, you can modify dhcpd6.conf by
21 # using DHCP snippets over the API or through the web interface.
22
23-option arch code 93 = unsigned integer 16; # RFC4578
24+option dhcp6.client-arch-type code 61 = array of unsigned integer 16; # RFC5970
25 option path-prefix code 210 = text; #RFC5071
26
27 #

Subscribers

People subscribed via source and target branches