Merge ~andreserl/maas:minor_pkg_improvements into maas:master

Proposed by Andres Rodriguez
Status: Merged
Approved by: Andres Rodriguez
Approved revision: 880ab7e8efc4ba083370cd88f53ac395d45869f8
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~andreserl/maas:minor_pkg_improvements
Merge into: maas:master
Diff against target: 93 lines (+17/-13)
7 files modified
debian/changelog (+3/-1)
debian/control (+3/-2)
debian/maas-cli.lintian-overrides (+1/-1)
debian/maas-common.lintian-overrides (+2/-1)
debian/maas-rack-controller.lintian-overrides (+1/-2)
debian/maas-region-api.lintian-overrides (+7/-5)
dev/null (+0/-1)
Reviewer Review Type Date Requested Status
Mike Pontillo (community) Approve
Review via email: mp+329628@code.launchpad.net

Commit message

Minor packaging improvements

To post a comment you must log in.
Revision history for this message
Mike Pontillo (mpontillo) wrote :

Looks good to me overall; some comments and questions below.

review: Approve
Revision history for this message
Andres Rodriguez (andreserl) :
880ab7e... by Andres Rodriguez

Remove typo

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index f3ba3d5..9b3eec2 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -4,8 +4,10 @@ maas (2.3.0~alpha3-0ubuntu1) UNRELEASED; urgency=medium
6 region controller in addition to the rack.
7 * Add /usr/lib/maas/maas-common script.
8 * Move to debhelper compat level 9.
9+ * debian/maas-common.links: Drop as it created a link for a binary that was
10+ already deprecated.
11
12- -- Mike Pontillo <mike.pontillo@canonical.com> Tue, 22 Aug 2017 15:28:42 -0700
13+ -- Andres Rodriguez <andreserl@ubuntu.com> Fri, 25 Aug 2017 12:18:37 -0400
14
15 maas (2.3.0~alpha2-6194-g7fb23b0-0ubuntu1) artful; urgency=medium
16
17diff --git a/debian/control b/debian/control
18index e0beb12..7992cf4 100644
19--- a/debian/control
20+++ b/debian/control
21@@ -2,7 +2,7 @@ Source: maas
22 Section: net
23 Priority: optional
24 Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
25-Build-Depends: debhelper (>= 8.1.0~),
26+Build-Depends: debhelper (>= 9~),
27 dh-apport,
28 dh-exec,
29 dh-python,
30@@ -59,6 +59,7 @@ Package: maas-common
31 Architecture: all
32 Depends: rsyslog,
33 ${misc:Depends},
34+ ${python3:Depends},
35 python3-maas-provisioningserver
36 Breaks: maas ( <= 0.1+bzr1048+dfsg-0ubuntu1 )
37 Replaces: maas ( <= 0.1+bzr1048+dfsg-0ubuntu1 )
38@@ -165,7 +166,7 @@ Architecture: all
39 Depends: python3-maas-client (= ${binary:Version}),
40 ${misc:Depends},
41 ${python3:Depends}
42-Conflicts: maas-region-controller-min (<= 1.5+bzr1909-0ubuntu1)
43+Breaks: maas-region-controller-min (<= 1.5+bzr1909-0ubuntu1)
44 Replaces: maas-region-controller-min (<= 1.5+bzr1909-0ubuntu1)
45 Description: MAAS client and command-line interface
46 This package contains the 'maas' command-line interface, which
47diff --git a/debian/maas-cli.links b/debian/maas-cli.links
48deleted file mode 100644
49index 3cb6829..0000000
50--- a/debian/maas-cli.links
51+++ /dev/null
52@@ -1 +0,0 @@
53-usr/bin/maas usr/bin/maas-cli
54diff --git a/debian/maas-cli.lintian-overrides b/debian/maas-cli.lintian-overrides
55index 0c046cc..f053786 100644
56--- a/debian/maas-cli.lintian-overrides
57+++ b/debian/maas-cli.lintian-overrides
58@@ -1 +1 @@
59-maas-cli: binary-without-manpage usr/bin/maas-cli
60+maas-cli: binary-without-manpage usr/bin/maas
61diff --git a/debian/maas-common.lintian-overrides b/debian/maas-common.lintian-overrides
62index 8a37f94..bb8d8f4 100644
63--- a/debian/maas-common.lintian-overrides
64+++ b/debian/maas-common.lintian-overrides
65@@ -1 +1,2 @@
66-maas-common: binary-without-manpage usr/lib/maas/maas-delete-file usr/lib/maas/maas-write-file
67+maas-common: binary-without-manpage
68+maas-common: maintainer-script-calls-systemctl
69diff --git a/debian/maas-rack-controller.lintian-overrides b/debian/maas-rack-controller.lintian-overrides
70index 6ae74f7..50d0059 100644
71--- a/debian/maas-rack-controller.lintian-overrides
72+++ b/debian/maas-rack-controller.lintian-overrides
73@@ -1,2 +1 @@
74-maas-rack-controller: binary-without-manpage usr/bin/uec2roottar usr/sbin/maas-dhcp-helper usr/lib/maas/maas-test-enlistment
75-maas-common: binary-without-manpage usr/lib/maas/network-monitor usr/lib/maas/beacon-monitor usr/lib/maas/dhcp-monitor
76+maas-rack-controller: binary-without-manpage
77diff --git a/debian/maas-region-api.lintian-overrides b/debian/maas-region-api.lintian-overrides
78index b76fff5..0c504dd 100644
79--- a/debian/maas-region-api.lintian-overrides
80+++ b/debian/maas-region-api.lintian-overrides
81@@ -1,5 +1,7 @@
82-maas-region-api: binary-without-manpage usr/sbin/maas
83-maas-region-api: script-not-executable etc/maas/templates/commissioning-user-data/snippets/maas_ipmi_autodetect.py
84-maas-region-api: script-not-executable etc/maas/templates/commissioning-user-data/snippets/maas_signal.py
85-maas-region-api: script-not-executable etc/maas/templates/commissioning-user-data/user_data.template
86-maas-region-api: script-not-executable etc/maas/templates/commissioning-user-data/snippets/maas_get.py
87+maas-region-api: maintainer-script-calls-systemctl
88+maas-region-api: command-with-path-in-maintainer-script
89+maas-region-api: executable-not-elf-or-script
90+maas-region-api: binary-without-manpage usr/sbin/maas-region
91+maas-region-api: binary-without-manpage usr/sbin/maas-region-admin
92+maas-region-api: binary-without-manpage usr/sbin/maas-generate-winrm-cert
93+maas-region-api: font-in-non-font-package

Subscribers

People subscribed via source and target branches