Code review comment for ~andreserl/maas:pkg-from-source

Revision history for this message
Mike Pontillo (mpontillo) wrote :

Nice! I approve, with suggestions.

I pulled your branch and tried it out; I noticed that when I ran `utilities/release-build`, it failed because the latest changelog entry's email address didn't match my GPG key.

I don't remember having to update the changelog first when packaging was separate; is your script supposed to do this automatically?

Running `dch -i` and re-running the script fixed it for me.

I noticed that you use the "pwd" command at the top of your scripts; it might be better to do what some of the other scripts do, such as:

    SANDBOX="$(cd "$(dirname "${BASH_SOURCE[0]}")"/.. && pwd)"

Then you can run the script from anywhere and it will find the correct $SANDBOX. (You can then `cd "$SANDBOX"`, for example, and be in the root directory of the checked-out code.)

review: Approve

« Back to merge proposal