Merge lp:~andreserl/charms/quantal/hacluster/ceph-ra-installation into lp:~openstack-charmers/charms/quantal/hacluster/trunk

Proposed by Andres Rodriguez
Status: Rejected
Rejected by: James Page
Proposed branch: lp:~andreserl/charms/quantal/hacluster/ceph-ra-installation
Merge into: lp:~openstack-charmers/charms/quantal/hacluster/trunk
Diff against target: 29 lines (+2/-5)
2 files modified
hooks/hooks.py (+1/-4)
revision (+1/-1)
To merge this branch: bzr merge lp:~andreserl/charms/quantal/hacluster/ceph-ra-installation
Reviewer Review Type Date Requested Status
James Page Abstain
Review via email: mp+149405@code.launchpad.net

Commit message

Always install ceph-resource-agents package. Otherwise there will be times on which the cluster will go to unmanaged mode because the resource agents will be installed after extra cluster nodes have been connected to the cluster. This is because it won't find the RA, making the cluster to go to unmanaged mode.

To post a comment you must log in.
Revision history for this message
James Page (james-page) wrote :

The only other approach I could thing of was to install the required resource agents in the principle charm prior to sending data to the hacluster subordinate.

I see the issue and this approach would resolve it; we would then not need to change the hacluster charm to support new resource agents either.

review: Approve
Revision history for this message
James Page (james-page) :
review: Abstain
Revision history for this message
James Page (james-page) wrote :

Sorry first comment should have been 'Comment' not approve.

I think this is probably what I saw when trying to use the openstack-resource-agents as well.

Unmerged revisions

14. By Andres Rodriguez

Update revision

13. By Andres Rodriguez

Always install ceph-resource-agents

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'hooks/hooks.py'
--- hooks/hooks.py 2013-02-13 23:44:37 +0000
+++ hooks/hooks.py 2013-02-19 21:10:29 +0000
@@ -18,7 +18,7 @@
18def install():18def install():
19 utils.juju_log('INFO', 'Begin install hook.')19 utils.juju_log('INFO', 'Begin install hook.')
20 utils.configure_source()20 utils.configure_source()
21 utils.install('corosync', 'pacemaker', 'python-netaddr', 'ipmitool')21 utils.install('corosync', 'pacemaker', 'python-netaddr', 'ipmitool', 'ceph-resource-agents')
22 utils.juju_log('INFO', 'End install hook.')22 utils.juju_log('INFO', 'End install hook.')
2323
2424
@@ -200,9 +200,6 @@
200 if True in [ra.startswith('ocf:openstack')200 if True in [ra.startswith('ocf:openstack')
201 for ra in resources.itervalues()]:201 for ra in resources.itervalues()]:
202 utils.install('openstack-resource-agents')202 utils.install('openstack-resource-agents')
203 if True in [ra.startswith('ocf:ceph')
204 for ra in resources.itervalues()]:
205 utils.install('ceph-resource-agents')
206203
207 utils.juju_log('INFO', 'Configuring and restarting corosync')204 utils.juju_log('INFO', 'Configuring and restarting corosync')
208 emit_corosync_conf()205 emit_corosync_conf()
209206
=== modified file 'revision'
--- revision 2013-02-13 23:44:37 +0000
+++ revision 2013-02-19 21:10:29 +0000
@@ -1,1 +1,1 @@
161162

Subscribers

People subscribed via source and target branches