Code review comment for lp:~andrebachmann-dd/qbzr/checkout_basedir

Revision history for this message
André Bachmann (andrebachmann-dd) wrote :

Ok, now to_location only gets the text from checkout_basedir if ui_mode is true. 'bzr qgetnew location' does work now.
But I disagree that this window should only respect the to_location from its outer code. If someone configures a base directory for checkouts, then this user wants it to be in the field 'to_location' - because if he/she doesn't wants it, he/she would have never configured this.

Concerning branchsource_basedir: My idea was to put at least a little bit of safety precaution that this field couldn't contain an invalid path. But I forgot that you can also put in a non-local path in it.
So I deleted os.path.abspath.

« Back to merge proposal