Code review comment for lp:~andrebachmann-dd/qbzr/checkout_basedir

Revision history for this message
IWATA Hidetaka (hid-iwata) wrote :

Hi.

`bzr qgetnew LOCATION` does not work. Command line arguments should be prior to global configuration.
Just focusing on GetNewWorkingTreeWindow class, `to_location` is parameter passed from outer code.
I think GetNewWorkingTreeWindow should respect it.

I want to specify url or string like "lp:~hid-iwata/" to branchsource_basedir.
But now, os.path.abspath breaks it. Is os.path.abspath realy needed?

« Back to merge proposal