Code review comment for lp:~andrebachmann-dd/bzr-explorer/fix-bzrlog

Revision history for this message
Martin Packman (gz) wrote :

You need to at least update the comments as you're updating the code. :)

Only real question is what version the split function was fixed, against how far back bzr-explorer tries to remain compatible. Checking now, seems it's been in bzrlib since 2.2, and bzr-explorer was updated in r513 to use the unbroken version, but these comments were missed so the quote hack didn't get reverted.

A cleanup of this module not to use command line strings would be nice, but isn't needed here. Just fix or delete the outdated comments and this will do.

review: Needs Fixing

« Back to merge proposal