Code review comment for lp:~andreas-pokorny/unity-system-compositor/expose-powerkey-state-and-screen-toggle-controller-interface

Revision history for this message
Andreas Pokorny (andreas-pokorny) wrote :

> What's going on here? Looks like the bug is still open to some extent (read
> the final comment on the remaining error states).
>
> I'm not sure this is the correct approach...shoul the telephony service be
> listening to the powerKey event or rather should it be listening to the power
> state change event from powerd or whomever

For RTM a simpler solution was used that would still results into the power state being toggled.
The expected behavior is that on an incoming call pressing the power key is consumed by rejecting/silencing the call, so without turning the display off or on in that case.

And yes the approach outlined here is ugly too.

« Back to merge proposal