> ~~~~
> 681+ std::shared_ptr<mir::shell::FocusController> const& controller,
> 682+ QSize const& displaySize,
> ~~~~
>
> Nit: const before type to be consistent with the rest of the code
True - but now that I look at the rest of the code - there is not consistency in that area. It seems like unity-mir is a battle ground between platform-api, mir and unity8 in coding style.
> ~~~~ ptr<mir: :shell: :FocusControlle r> const& controller,
> 681+ std::shared_
> 682+ QSize const& displaySize,
> ~~~~
>
> Nit: const before type to be consistent with the rest of the code
True - but now that I look at the rest of the code - there is not consistency in that area. It seems like unity-mir is a battle ground between platform-api, mir and unity8 in coding style.