Mir

Code review comment for lp:~andreas-pokorny/mir/use-lifecycleevent-in-mirserver

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

*Needs discussion*

OK, I've thought about it and read the spec.

I think the confusion comes from a mismatch between MirLifecycleState and the design.

"Event: application_about_to_suspend

"This event is triggered when the application is about to be suspended. Application authors can rely on this event to account for the situation that the UI will not be visible to the user anymore and that they will be granted at most minor CPU timeslices and no GPU timeslices. The event is accompanied by an archive that application authors can rely on to store application-specific state. In addition, an application instance is granted a limited amount of time for carrying out any preparations to go to suspend. After this time has elapsed, the system executes the transition." (Draft: Application Model)

It does makes sense to automatically propagate this to clients. But is that what mir_lifecycle_event_will_pause means? I think it has been conflated with:

"Event: application_about_to_stop

"This event is triggered when the application is about to be terminated, i.e., the process containing the application instance will be terminated. The event is accompanied by an archive that application authors can rely on to store application-specific state. In addition, an application instance is granted a limited amount of time for carrying out any preparations to go to suspend. After this time has elapsed, the system executes the transition."

review: Needs Information

« Back to merge proposal