Mir

Code review comment for lp:~andreas-pokorny/mir/use-input-channel-to-send-input

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

> So in the end we will have to go all the way and refactor
> android::InputDispatcher already now. :(
>
> Making it only shepherd events through android::InputChannels (exactly like
> its stripped-down version existing in lp:~unity-team/+junk/qpa-mirserver) and
> leaving the responsibility of selecting which input channel gets the input
> event coming out of the android::InputReader to another entity (in the qt
> compositor case, the QQuickWindow dispatch logic that selects the qml item
> that will receive incoming input) that receives all input coming out of
> android::InputReader and calls mir::input::Surface::consume_event on the
> surface it decides that should receive the event, if any.

Then, that stripped down android::InputDispatcher should probably be renamed to something else to avoid confusion since the selection of the recipient of incoming input events is what a event/input dispatcher is supposed to do.

« Back to merge proposal