Mir

Code review comment for lp:~andreas-pokorny/mir/split-main-loop-and-fix-races

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> Mostly happy I think.
>
> Not sure I see the point in the mir::Loop interface? Yes the main loop and the
> timer service both have run/stop methods, but which component really benefits
> from the loop interface?

Mmmm.

Adding an interface whose purpose is unclear to the wrong namespace is enough to make me unhappy with the MP.

review: Needs Fixing

« Back to merge proposal