Mir

Code review comment for lp:~andreas-pokorny/mir/split-main-loop-and-fix-races

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

41 + virtual std::shared_ptr<mir::time::Timer> the_timer();

"mir::" is not needed.

~~~~

79 +namespace mir
80 +{
81 +class Loop

I think "Loop" is an uninformative name (what is it?) in the wrong namespace (what role it has in setting up the server)?

Should it be time::Scheduler or todo::Scheduler?

review: Needs Fixing

« Back to merge proposal