1061 + // of boost::asio only allowing static methods inside the taits type.
s/taits/traits/
~~~~
1372 + return std::make_shared<mc::TimeoutFrameDroppingPolicyFactory>(the_timer_service(),
TimeoutFrameDroppingPolicyFactory requires a shared_ptr<Timer>, not a shared_ptr<TimerService> - this reinforces my feeling that these interfaces are wrong. It also requires an extra header here that shouldn't be needed. Vis:
1363 +#include "mir/time/timer_service.h"
« Back to merge proposal
1061 + // of boost::asio only allowing static methods inside the taits type.
s/taits/traits/
~~~~
1372 + return std::make_ shared< mc::TimeoutFram eDroppingPolicy Factory> (the_timer_ service( ),
TimeoutFrameDro ppingPolicyFact ory requires a shared_ptr<Timer>, not a shared_ ptr<TimerServic e> - this reinforces my feeling that these interfaces are wrong. It also requires an extra header here that shouldn't be needed. Vis:
1363 +#include "mir/time/ timer_service. h"