Mir

Code review comment for lp:~andreas-pokorny/mir/split-main-loop-and-fix-races

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

1061 + // of boost::asio only allowing static methods inside the taits type.

s/taits/traits/

~~~~

1372 + return std::make_shared<mc::TimeoutFrameDroppingPolicyFactory>(the_timer_service(),

TimeoutFrameDroppingPolicyFactory requires a shared_ptr<Timer>, not a shared_ptr<TimerService> - this reinforces my feeling that these interfaces are wrong. It also requires an extra header here that shouldn't be needed. Vis:

1363 +#include "mir/time/timer_service.h"

review: Needs Fixing

« Back to merge proposal