Code review comment for lp:~andreas-pokorny/mir/pixel-format-utils

105 + return (format > mir_pixel_format_invalid &&
106 + format < mir_pixel_formats);

If we are going to range-check the enums, it would be good to have a test for the upper edge too:

EXPECT_FALSE(valid_pixel_format(mir_pixels_formats));

169 +#include <gmock/gmock.h>

Not needed.

92 +namespace mir
93 +{
94 +namespace graphics
95 +{

Have we decided to allow this scheme in implementation files (vs "using mg=...; mg::...") ?