Code review comment for lp:~andreas-pokorny/mir/move-key-repeat-into-input-platforms

> Yay for deleting code!
>
> + std::shared_ptr<mir::time::Clock> const&
> clock)
> + : report{report},
>
> + std::unique_ptr<udev::Context>&& udev_context)
> + : report(report),
>
> +mix::XInputDevice::XInputDevice(InputDeviceInfo const& device_info,
> std::shared_ptr<::Display> const& display)
> + : display{display}, info(device_info)
>
> + std::shared_ptr<::Display> const& conn)
> + : x11_connection{conn},
>
> The : needs to go on the same line as the ctor (at lease according to the
> coding style). I see most of those were on the init list line before this
> branch. Feel free to fix them (just a nit).

We have both variants in the style guide - for some reason our current clang-format setup seems to prefer the version above..

>
> +class Alarm;
> I dont see that namespace used? (Unless i missed it :). Do we need this
> forward dec?

ack removed.

> Do we just not care about the key_code here?
> sink->handle_input(*builder->key_event(event_time,
> mir_keyboard_action_repeat, 0, code));

I guess testing that the actual key code is repeated might be reasonable thing to test..