Mir

Code review comment for lp:~andreas-pokorny/mir/libinput-platform-touch-pad-settings

Revision history for this message
Andreas Pokorny (andreas-pokorny) wrote :

> just some nits:
>
> + TouchPadSettings() {}
> not needed

This is needed when I want to use that with mir::optional_value, as it initializes stuff with curly braces. Also the = default constructor is not enough... Without that clang treats it as a pod and assumes a by member initialization.

fixiing the rest now

« Back to merge proposal