Mir

Merge lp:~andreas-pokorny/mir/libinput-package into lp:mir

Proposed by Andreas Pokorny
Status: Merged
Approved by: Andreas Pokorny
Approved revision: no longer in the source branch.
Merged at revision: 2960
Proposed branch: lp:~andreas-pokorny/mir/libinput-package
Merge into: lp:mir
Prerequisite: lp:~andreas-pokorny/mir/libinput-platform
Diff against target: 97 lines (+24/-3)
6 files modified
cmake/ABICheck.cmake (+2/-1)
debian/control (+14/-0)
debian/mir-platform-input-evdev2.install (+1/-0)
src/platforms/evdev/CMakeLists.txt (+3/-0)
tools/run_abi_compliance_checker.sh (+2/-1)
tools/update_package_abis.sh (+2/-1)
To merge this branch: bzr merge lp:~andreas-pokorny/mir/libinput-package
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Alexandros Frantzis (community) Approve
Alan Griffiths Approve
Daniel van Vugt Approve
Kevin DuBois (community) Approve
Review via email: mp+269534@code.launchpad.net

Commit message

install libinput as a versioned driver package and enable ABI trace dump generation

Description of the change

extends the debian settings and cmake to install as input-evdev.so.2

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Kevin DuBois (kdub) wrote :

lgtm

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

(1) Needs fixing per above:

/mir/src/platforms/evdev/libinput_device.cpp:332:53: error: 'libinput_device_get_device_group' was not declared in this scope
     return libinput_device_get_device_group(device());
                                                     ^

/mir/src/platforms/evdev/libinput_device.cpp:332:12: error: use of undeclared identifier 'libinput_device_get_device_group'
    return libinput_device_get_device_group(device());
           ^

(2) Needs information: What's this?;
46 - ${Boost_PROGRAM_OPTIONS_LIBRARY}
47 + ${Boost_PROGRAM_OPTIONS_LIBRARY}G

review: Needs Information
Revision history for this message
Andreas Pokorny (andreas-pokorny) wrote :

Yes, the group handling I am using was only added in 0.12. The silo for vivid+overlay is on the way to get 0.22 + touchscreen patches into the phone ppa.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Approved pending Jenkins. This one (or rather the prerequisite) should not land till Jenkins is back online and has tested it.

review: Approve
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Also nit: Instead of:

39 + SUFFIX ".so.${MIR_SERVER_INPUT_PLATFORM_ABI}"

You should set the target property "SOVERSION" to "${MIR_SERVER_INPUT_PLATFORM_ABI}".

Because the SOVERSION ABI string isn't just part of the file name, but a property that the linker bakes into the binary.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

3: Unknown package: debian/control contains versioned package mir-platform-input-evdev but it is unknown to this script
3: The package list in this script needs to be updated

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

OK

review: Approve
Revision history for this message
Alexandros Frantzis (afrantzis) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'cmake/ABICheck.cmake'
--- cmake/ABICheck.cmake 2015-09-08 21:22:41 +0000
+++ cmake/ABICheck.cmake 2015-09-22 18:46:53 +0000
@@ -89,6 +89,7 @@
89make_lib_descriptor(clientplatformandroid LIBRARY_HEADER ${CMAKE_SOURCE_DIR}/src/include/client/mir/client_platform_factory.h)89make_lib_descriptor(clientplatformandroid LIBRARY_HEADER ${CMAKE_SOURCE_DIR}/src/include/client/mir/client_platform_factory.h)
90make_lib_descriptor(platformgraphicsandroid LIBRARY_HEADER ${CMAKE_SOURCE_DIR}/include/platform/mir/graphics/platform.h)90make_lib_descriptor(platformgraphicsandroid LIBRARY_HEADER ${CMAKE_SOURCE_DIR}/include/platform/mir/graphics/platform.h)
91endif()91endif()
92make_lib_descriptor(platforminputevdev LIBRARY_HEADER ${CMAKE_SOURCE_DIR}/include/platform/mir/input/)
9293
93add_custom_target(abi-release-dump94add_custom_target(abi-release-dump
94 COMMAND /bin/sh -c '${CMAKE_SOURCE_DIR}/tools/generate-abi-base-dump.sh ${CMAKE_SOURCE_DIR}'95 COMMAND /bin/sh -c '${CMAKE_SOURCE_DIR}/tools/generate-abi-base-dump.sh ${CMAKE_SOURCE_DIR}'
@@ -125,7 +126,7 @@
125 )126 )
126endmacro(_define_abi_check_for)127endmacro(_define_abi_check_for)
127128
128set(the_libs mirserver mirclient mircommon mirplatform mircookie)129set(the_libs mirserver mirclient mircommon mirplatform mircookie mirplatforminputevdev)
129if(MIR_BUILD_PLATFORM_MESA_KMS)130if(MIR_BUILD_PLATFORM_MESA_KMS)
130 set(the_libs ${the_libs} mirclientplatformmesa mirplatformgraphicsmesakms)131 set(the_libs ${the_libs} mirclientplatformmesa mirplatformgraphicsmesakms)
131endif()132endif()
132133
=== modified file 'debian/control'
--- debian/control 2015-09-22 13:50:47 +0000
+++ debian/control 2015-09-22 18:46:53 +0000
@@ -331,6 +331,20 @@
331 Contains the shared libraries required for the Mir server to interact with331 Contains the shared libraries required for the Mir server to interact with
332 the hardware platform using the Android drivers.332 the hardware platform using the Android drivers.
333333
334Package: mir-platform-input-evdev2
335Section: libs
336Architecture: linux-any
337Multi-Arch: same
338Pre-Depends: ${misc:Pre-Depends}
339Depends: ${misc:Depends},
340 ${shlibs:Depends},
341Description: Display server for Ubuntu - input platform library
342 Mir is a display server running on linux systems, with a focus on efficiency,
343 robust operation and a well-defined driver model.
344 .
345 Contains the shared libraries required for the Mir server to interact with
346 the input hardware using the evdev interface.
347
334Package: mir-client-platform-mesa3348Package: mir-client-platform-mesa3
335Section: libs349Section: libs
336Architecture: linux-any350Architecture: linux-any
337351
=== added file 'debian/mir-platform-input-evdev2.install'
--- debian/mir-platform-input-evdev2.install 1970-01-01 00:00:00 +0000
+++ debian/mir-platform-input-evdev2.install 2015-09-22 18:46:53 +0000
@@ -0,0 +1,1 @@
1usr/lib/*/mir/server-platform/input-evdev.so.2
02
=== modified file 'src/platforms/evdev/CMakeLists.txt'
--- src/platforms/evdev/CMakeLists.txt 2015-09-10 13:39:03 +0000
+++ src/platforms/evdev/CMakeLists.txt 2015-09-22 18:46:53 +0000
@@ -29,6 +29,7 @@
29 OUTPUT_NAME input-evdev29 OUTPUT_NAME input-evdev
30 LIBRARY_OUTPUT_DIRECTORY ${CMAKE_LIBRARY_OUTPUT_DIRECTORY}/server-modules30 LIBRARY_OUTPUT_DIRECTORY ${CMAKE_LIBRARY_OUTPUT_DIRECTORY}/server-modules
31 PREFIX ""31 PREFIX ""
32 SUFFIX ".so.${MIR_SERVER_INPUT_PLATFORM_ABI}"
32 LINK_FLAGS "-Wl,--exclude-libs=ALL -Wl,--version-script,${MIR_INPUT_PLATFORM_VERSION_SCRIPT}"33 LINK_FLAGS "-Wl,--exclude-libs=ALL -Wl,--version-script,${MIR_INPUT_PLATFORM_VERSION_SCRIPT}"
33)34)
3435
@@ -38,3 +39,5 @@
38 ${Boost_PROGRAM_OPTIONS_LIBRARY}39 ${Boost_PROGRAM_OPTIONS_LIBRARY}
39 ${LIBINPUT_LDFLAGS} ${LIBINPUT_LIBRARIES}40 ${LIBINPUT_LDFLAGS} ${LIBINPUT_LIBRARIES}
40)41)
42
43install(TARGETS mirplatforminputevdev LIBRARY DESTINATION ${MIR_SERVER_PLATFORM_PATH})
4144
=== modified file 'tools/run_abi_compliance_checker.sh'
--- tools/run_abi_compliance_checker.sh 2015-06-05 06:28:36 +0000
+++ tools/run_abi_compliance_checker.sh 2015-09-22 18:46:53 +0000
@@ -9,7 +9,8 @@
9 ["mirclientplatformandroid"]="MIR_CLIENT_PLATFORM_ABI" \9 ["mirclientplatformandroid"]="MIR_CLIENT_PLATFORM_ABI" \
10 ["mirclientplatformmesa"]="MIR_CLIENT_PLATFORM_ABI" \10 ["mirclientplatformmesa"]="MIR_CLIENT_PLATFORM_ABI" \
11 ["mirplatformgraphicsandroid"]="MIR_SERVER_GRAPHICS_PLATFORM_ABI" \11 ["mirplatformgraphicsandroid"]="MIR_SERVER_GRAPHICS_PLATFORM_ABI" \
12 ["mirplatformgraphicsmesakms"]="MIR_SERVER_GRAPHICS_PLATFORM_ABI" )12 ["mirplatformgraphicsmesakms"]="MIR_SERVER_GRAPHICS_PLATFORM_ABI" \
13 ["mirplatforminputevdev"]="MIR_SERVER_INPUT_PLATFORM_ABI" )
1314
14print_help_and_exit()15print_help_and_exit()
15{16{
1617
=== modified file 'tools/update_package_abis.sh'
--- tools/update_package_abis.sh 2015-09-08 21:22:41 +0000
+++ tools/update_package_abis.sh 2015-09-22 18:46:53 +0000
@@ -21,7 +21,8 @@
21 mir-client-platform-mesa:MIR_CLIENT_PLATFORM_ABI \21 mir-client-platform-mesa:MIR_CLIENT_PLATFORM_ABI \
22 mir-platform-graphics-android:MIR_SERVER_GRAPHICS_PLATFORM_ABI \22 mir-platform-graphics-android:MIR_SERVER_GRAPHICS_PLATFORM_ABI \
23 mir-platform-graphics-mesa-x:MIR_SERVER_GRAPHICS_PLATFORM_ABI \23 mir-platform-graphics-mesa-x:MIR_SERVER_GRAPHICS_PLATFORM_ABI \
24 mir-platform-graphics-mesa-kms:MIR_SERVER_GRAPHICS_PLATFORM_ABI"24 mir-platform-graphics-mesa-kms:MIR_SERVER_GRAPHICS_PLATFORM_ABI \
25 mir-platform-input-evdev:MIR_SERVER_INPUT_PLATFORM_ABI"
2526
26package_name()27package_name()
27{28{

Subscribers

People subscribed via source and target branches